From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 781EF2E7635 for ; Fri, 30 Jan 2026 10:55:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769770546; cv=none; b=q4A63uQyxNHa0ZPbZjtQZ89OEgeBkRuu06cCcOMg4D3jBanZp1pxIyMJEh2qHnFsgC33BBrweJ69FBVhpwITAA2FMTLJHp/km5iQuAZCqLnFb//iOFYyaG0CmMu49NIPCha7HWYIgoGVsrdn2zOZT6OjGN64jMbNQCzBrovMBeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769770546; c=relaxed/simple; bh=PkDMUmwbrc+2s6U1Pahqwty6wSR/IyewHnZG6gCgbtc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kSGAphtYzmfKINN9cARQHWvn4y+0X2O4lValNUK5gbFp92Eydd7AjFkAZ3K2OuuCfJm7sOSkiukvlyp58eW77SbQeYpTkQk1UKFuI65QSMHpfPmbXid0VZep9D1yjTSKEtroMlU9aDd5gZPzc9aU78itZu7ceQB72eBHcli5Pqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rcCxmIpU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=BrtUOyLO; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rcCxmIpU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=BrtUOyLO; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rcCxmIpU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="BrtUOyLO"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rcCxmIpU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="BrtUOyLO" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4FA193466D; Fri, 30 Jan 2026 10:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769770538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l1ds2yI+UVu5Uzi3WpC0y8kU827Nwm3vhRyobaWGStE=; b=rcCxmIpU31Yxm33paG7QJWguZ9bdO7PT3BDGuU9qW4V8QNBXIO27zMAVARIQlQqL/kgqMd 5SWlhkka0312QWm4f8v0K+uwXqe0e/v6XwFWpDaoem3AtkDsn7BFQa1Em/LnbO7lWLbW+G DC2ouk2ab5ywbK3xvpAlQpRjewJsmIc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769770538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l1ds2yI+UVu5Uzi3WpC0y8kU827Nwm3vhRyobaWGStE=; b=BrtUOyLOEs8hsZzUPcxgqUq545JTugnezJ6gBafYfyDNntMqGVRl42Q6JmVtGwFjxMgF4p Z57sL8oi8DDtZ0Dg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1769770538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l1ds2yI+UVu5Uzi3WpC0y8kU827Nwm3vhRyobaWGStE=; b=rcCxmIpU31Yxm33paG7QJWguZ9bdO7PT3BDGuU9qW4V8QNBXIO27zMAVARIQlQqL/kgqMd 5SWlhkka0312QWm4f8v0K+uwXqe0e/v6XwFWpDaoem3AtkDsn7BFQa1Em/LnbO7lWLbW+G DC2ouk2ab5ywbK3xvpAlQpRjewJsmIc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1769770538; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l1ds2yI+UVu5Uzi3WpC0y8kU827Nwm3vhRyobaWGStE=; b=BrtUOyLOEs8hsZzUPcxgqUq545JTugnezJ6gBafYfyDNntMqGVRl42Q6JmVtGwFjxMgF4p Z57sL8oi8DDtZ0Dg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 249C53EA61; Fri, 30 Jan 2026 10:55:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id fNg5ByqOfGlycwAAD6G6ig (envelope-from ); Fri, 30 Jan 2026 10:55:38 +0000 Date: Fri, 30 Jan 2026 11:55:27 +0100 From: Jean Delvare To: Antoine Lassagne Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware/dmi: Include product_family info to modalias Message-ID: <20260130115527.768e1ef1@endymion> In-Reply-To: <20260116130315.1724612-1-antoine.lassagne@canonical.com> References: <20260116130315.1724612-1-antoine.lassagne@canonical.com> Organization: SUSE Linux X-Mailer: Claws Mail 4.2.0 (GTK 3.24.43; x86_64-suse-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -3.80 X-Spamd-Result: default: False [-3.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_ORG_HEADER(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-Spam-Level: X-Spam-Flag: NO Hi Antoine, On Fri, 16 Jan 2026 14:03:15 +0100, Antoine Lassagne wrote: > Some platforms rely on modalias to customize configuration, > the product family helps to identify the hardware. > > Add product_family to modalias for better utilization. > This patch mimics commit e26f023e01ef ("firmware/dmi: > Include product_sku info to modalias") that did the same > for product_sku, and commit f97a2103f1a7 ("firmware: dmi: > Move product_sku info to the end of the modalias") that > fixed regressions caused by the added field notbeing in Missing space (no worry, I'll fix it as I commit the patch). > the end of the list. > > Signed-off-by: Antoine Lassagne > --- > drivers/firmware/dmi-id.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c > index d19c78a78ae3..6b5c7bf35387 100644 > --- a/drivers/firmware/dmi-id.c > +++ b/drivers/firmware/dmi-id.c > @@ -96,6 +96,7 @@ static ssize_t get_modalias(char *buffer, size_t buffer_size) > { "ct", DMI_CHASSIS_TYPE }, > { "cvr", DMI_CHASSIS_VERSION }, > { "sku", DMI_PRODUCT_SKU }, > + { "pfa", DMI_PRODUCT_FAMILY }, > { NULL, DMI_NONE } > }; > Looks reasonable. Out of curiosity, what is your practical use case? -- Jean Delvare SUSE L3 Support