From: SeongJae Park <sj@kernel.org>
To: lirongqing <lirongqing@baidu.com>
Cc: SeongJae Park <sj@kernel.org>,
akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon: remove __read_mostly from memory_idle_ms_percentiles
Date: Fri, 30 Jan 2026 07:38:12 -0800 [thread overview]
Message-ID: <20260130153813.784-1-sj@kernel.org> (raw)
In-Reply-To: <20260130085603.1814-1-lirongqing@baidu.com>
On Fri, 30 Jan 2026 03:56:03 -0500 lirongqing <lirongqing@baidu.com> wrote:
> From: Li RongQing <lirongqing@baidu.com>
>
> The 'memory_idle_ms_percentiles' array in DAMON_STAT is updated
> frequently by the kernel to reflect the latest idle time statistics.
> Marking it as '__read_mostly' is inappropriate for data that is
> regularly written to, as it can lead to cache pollution in the
> read-mostly section.
>
> Remove the '__read_mostly' annotation to accurately reflect the
> variable's usage pattern.
Nice catch, thank you Li!
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-01-30 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 8:56 [PATCH] mm/damon: remove __read_mostly from memory_idle_ms_percentiles lirongqing
2026-01-30 15:38 ` SeongJae Park [this message]
2026-01-30 15:43 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260130153813.784-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lirongqing@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.