From: Eric Biggers <ebiggers@kernel.org>
To: Daniel Hodges <hodgesd@meta.com>
Cc: David Howells <dhowells@redhat.com>,
Lukas Wunner <lukas@wunner.de>,
Ignat Korchagin <ignat@cloudflare.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: pkcs7 - use constant-time digest comparison
Date: Sat, 31 Jan 2026 20:41:35 -0800 [thread overview]
Message-ID: <20260201044135.GA71244@quark> (raw)
In-Reply-To: <20260201035503.3945067-1-hodgesd@meta.com>
On Sat, Jan 31, 2026 at 07:55:03PM -0800, Daniel Hodges wrote:
> This creates a timing side-channel that could allow an
> attacker to forge valid signatures by measuring verification time
> and recovering the expected digest value byte-by-byte.
Good luck with that. The memcmp just checks that the CMS object
includes the hash of the data as a signed attribute. It's a consistency
check of two attacker-controlled values, which happens before the real
signature check. You may be confusing it with a MAC comparison.
- Eric
next prev parent reply other threads:[~2026-02-01 4:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 3:55 [PATCH] crypto: pkcs7 - use constant-time digest comparison Daniel Hodges
2026-02-01 4:41 ` Eric Biggers [this message]
2026-02-01 10:55 ` Ignat Korchagin
2026-02-01 13:07 ` Daniel Hodges
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260201044135.GA71244@quark \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=hodgesd@meta.com \
--cc=ignat@cloudflare.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.