From: Peter Zijlstra <peterz@infradead.org>
To: Kees Cook <kees@debian.org>
Cc: mingo@kernel.org, oleg@redhat.com, linux-kernel@vger.kernel.org,
debian-kernel@lists.debian.org, kees@kernel.org
Subject: Re: [PATCH] seqlock: Allow UBSAN to fail optimizing
Date: Sun, 1 Feb 2026 12:47:41 +0100 [thread overview]
Message-ID: <20260201114741.GA3016024@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <aX5NG2aOyvTXU6qZ@outflux.net>
On Sat, Jan 31, 2026 at 10:42:35AM -0800, Kees Cook wrote:
> On Sat, Jan 31, 2026 at 10:39:42AM +0100, Salvatore Bonaccorso wrote:
> > Kees, Peter approached the Debian kernel list above to drop
> > CONFIG_UBSAN again, which, so I think we need to revert your
> > 6cfadabfe015 ("Enable UBSAN_BOUNDS and UBSAN_SHIFT"):
> > https://salsa.debian.org/kernel-team/linux/-/commit/6cfadabfe015fa0d659fc8e3efd495cbcae3e44e
> >
> > I have make a MR for our packaging for the change in
> > https://salsa.debian.org/kernel-team/linux/-/merge_requests/1804
>
> I am strongly opposed -- this undoes years of security flaw mitigation
> work and leaves Debian (and only Debian!) exposed to trivial array index
> overflows. The bounds sanitizer is the corner stone of memory safety
> for C, and is not some "experimental" feature. GCC has a long history
> of trouble with inlining, so this is not something unique to enabling
> this feature.
>
> I replied similarly to the PR. This would be a major mistake to disable.
Why the heck is bounds checking part of UBSAN? The simple fix here is to
get it out from CONFIG_UBSAN, so that CONFIG_UBSAN is debug only crap.
Notably, none of the UBSAN configs that tripped the optimization fail
even had bounds checking enabled.
next prev parent reply other threads:[~2026-02-01 11:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 11:07 [PATCH] seqlock: Allow UBSAN to fail optimizing Peter Zijlstra
2026-01-31 9:39 ` Salvatore Bonaccorso
2026-01-31 18:42 ` Kees Cook
2026-02-01 11:47 ` Peter Zijlstra [this message]
2026-02-02 3:39 ` Kees Cook
2026-02-02 8:29 ` Peter Zijlstra
2026-02-02 16:01 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260201114741.GA3016024@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=debian-kernel@lists.debian.org \
--cc=kees@debian.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.