From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Pierrick Bouvier <pierrick.bouvier@linaro.org>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Stefano Garzarella <sgarzare@redhat.com>,
Harsh Prateek Bora <harshpb@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH 2/6] include/hw/virtio/virtio-access.h: remove target specifics define
Date: Mon, 2 Feb 2026 02:40:00 -0500 [thread overview]
Message-ID: <20260202023914-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <299f59f7-62c3-42f4-99c4-b7c7cfb111c2@linaro.org>
On Sun, Feb 01, 2026 at 11:36:04PM +0100, Philippe Mathieu-Daudé wrote:
> On 31/1/26 18:48, Michael S. Tsirkin wrote:
> > On Fri, Jan 30, 2026 at 06:00:56PM -0800, Pierrick Bouvier wrote:
> > > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> >
> > Performance impact?
> >
> > the reason we have these is for performance ...
>
> If this is a worry, we can declare the virtio LD/ST helpers in
> VirtIODevice and set them in virtio_reset(); the call chain will
> be even simpler than doing that check on every calls.
Would make them indirect calls though, no?
So I suspect the performance of this needs to be tested, anyway.
--
MST
next prev parent reply other threads:[~2026-02-02 7:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 2:00 [PATCH 0/6] single-binary: hw/virtio Pierrick Bouvier
2026-01-31 2:00 ` [PATCH 1/6] target-info: add target_base_ppc, target_ppc and target_ppc64 Pierrick Bouvier
2026-02-01 22:28 ` Philippe Mathieu-Daudé
2026-02-01 23:11 ` Philippe Mathieu-Daudé
2026-01-31 2:00 ` [PATCH 2/6] include/hw/virtio/virtio-access.h: remove target specifics define Pierrick Bouvier
2026-01-31 17:48 ` Michael S. Tsirkin
2026-02-01 22:36 ` Philippe Mathieu-Daudé
2026-02-01 22:41 ` Philippe Mathieu-Daudé
2026-02-01 23:20 ` Philippe Mathieu-Daudé
2026-02-02 1:25 ` Pierrick Bouvier
2026-02-02 7:40 ` Michael S. Tsirkin [this message]
2026-02-02 11:03 ` Philippe Mathieu-Daudé
2026-02-02 1:24 ` Pierrick Bouvier
2026-02-02 7:50 ` Michael S. Tsirkin
2026-02-02 18:00 ` Stefan Hajnoczi
2026-02-02 19:12 ` Pierrick Bouvier
2026-01-31 2:00 ` [PATCH 3/6] include/hw/ppc/spapr: extract SPAPR_MAX_RAM_SLOTS in a new header Pierrick Bouvier
2026-02-01 22:26 ` Philippe Mathieu-Daudé
2026-02-01 23:11 ` Philippe Mathieu-Daudé
2026-01-31 2:00 ` [PATCH 4/6] hw/virtio/vhost-user: make compilation unit common Pierrick Bouvier
2026-02-01 23:11 ` Philippe Mathieu-Daudé
2026-01-31 2:00 ` [PATCH 5/6] hw/virtio/virtio-qmp: " Pierrick Bouvier
2026-02-01 23:11 ` Philippe Mathieu-Daudé
2026-01-31 2:01 ` [PATCH 6/6] hw/virtio/: make all compilation units common Pierrick Bouvier
2026-02-01 22:28 ` Philippe Mathieu-Daudé
2026-02-01 23:13 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202023914-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.