From: Jakub Kicinski <kuba@kernel.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: netdev@vger.kernel.org, stable@vger.kernel.org,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH net v4] net: cpsw_new: Execute ndo_set_rx_mode callback in a work queue
Date: Mon, 2 Feb 2026 16:19:18 -0800 [thread overview]
Message-ID: <20260202161918.54be9315@kernel.org> (raw)
In-Reply-To: <aX6pHiB0tk6xvrCX@pek-khao-d3>
On Sun, 1 Feb 2026 09:15:10 +0800 Kevin Hao wrote:
> > > - unregister_netdev(cpsw->slaves[i].ndev);
> > > + priv = netdev_priv(ndev);
> > > + disable_work_sync(&priv->rx_mode_work);
> > > + unregister_netdev(ndev);
> >
> > I understand that this is safe but I think that more logical ordering
> > would be to shut things down _after_ object is unregistered.
>
> I'm a bit confused—are you suggesting that we move disable_work_sync() after
> unregister_netdev()? If that's the case, the scheduled cpsw_ndo_set_rx_mode_work()
> could potentially run after the network device has been unregistered, leading to
> a use-after-free issue. Or am I misunderstanding something here?
Unregistered device is not freed yet. The netdev is only freed after
.remove routine returns. Passing unregistered netdev to netif_running()
is safe and will return false.
next prev parent reply other threads:[~2026-02-03 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 5:34 [PATCH net v4] net: cpsw_new: Execute ndo_set_rx_mode callback in a work queue Kevin Hao
2026-01-31 20:41 ` Jakub Kicinski
2026-02-01 1:15 ` Kevin Hao
2026-02-03 0:19 ` Jakub Kicinski [this message]
2026-02-03 1:18 ` Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202161918.54be9315@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haokexin@gmail.com \
--cc=kuniyu@google.com \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=stable@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.