From: Ido Schimmel <idosch@nvidia.com>
To: David Corvaglia <david@corvaglia.dev>
Cc: razor@blackwall.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
bridge@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: bridge: use sysfs_emit instead of sprintf
Date: Mon, 2 Feb 2026 19:44:09 +0200 [thread overview]
Message-ID: <20260202174409.GA127339@shredder> (raw)
In-Reply-To: <0100019c1d2d46e0-a083f912-ac82-47e8-8cbb-ac9d70355ed3-000000@email.amazonses.com>
On Mon, Feb 02, 2026 at 07:07:12AM +0000, David Corvaglia wrote:
> @@ -677,9 +677,8 @@ static ssize_t multicast_query_response_interval_show(
> struct device *d, struct device_attribute *attr, char *buf)
> {
> struct net_bridge *br = to_bridge(d);
> - return sprintf(
> - buf, "%lu\n",
> - jiffies_to_clock_t(br->multicast_ctx.multicast_query_response_interval));
> + return sysfs_emit(buf, "%lu\n",
> + jiffies_to_clock_t(br->multicast_ctx.multicast_query_response_interval));
> }
I get:
$ b4 shazam -k 0100019c1d2d46e0-a083f912-ac82-47e8-8cbb-ac9d70355ed3-000000@email.amazonses.com
[...]
● checkpatch.pl: 392: ERROR: code indent should use tabs where possible
[...]
$ scripts/checkpatch.pl -g HEAD
ERROR: code indent should use tabs where possible
#332: FILE: net/bridge/br_sysfs_br.c:681:
+^I^I jiffies_to_clock_t(br->multicast_ctx.multicast_query_response_interval));$
total: 1 errors, 0 warnings, 0 checks, 495 lines checked
next prev parent reply other threads:[~2026-02-02 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 7:07 [PATCH net-next v2] net: bridge: use sysfs_emit instead of sprintf David Corvaglia
2026-02-02 17:44 ` Ido Schimmel [this message]
2026-02-02 19:03 ` David Corvaglia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202174409.GA127339@shredder \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=david@corvaglia.dev \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.