From: Jakub Kicinski <kuba@kernel.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [net-next 4/4] net: ethernet: renesas: rcar_gen4_ptp: Hide private data from users
Date: Mon, 2 Feb 2026 19:11:21 -0800 [thread overview]
Message-ID: <20260202191121.71326ca2@kernel.org> (raw)
In-Reply-To: <20260201183745.1075399-5-niklas.soderlund+renesas@ragnatech.se>
On Sun, 1 Feb 2026 19:37:45 +0100 Niklas Söderlund wrote:
> The Gen4 PTP helper module is already used by RTSN and RSWITCH to
> support PTP clocks and will be used by RAVB too. Hide the Gen4 PTP
> private data structure to make sure none of the users poke at it.
>
> This will be more important for RAVB use-cases as more then one RAVB
> device will need to cooperate using one PTP clock source.
IMO hiding type definitions in C is an anti-pattern.
Sooner or later you'll need a sizeof or a static inline helper
and you'll have to bend over backwards to access the type info.
We can take this if you have a strong preference, but please
think again if you really need this or it's a code cleanliness
instinct carried over from objective programming, hence foreign..
next prev parent reply other threads:[~2026-02-03 3:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 18:37 [net-next 0/4] net: ethernet: renesas: rcar_gen4_ptp: Hide private data Niklas Söderlund
2026-02-01 18:37 ` [net-next 1/4] net: ethernet: renesas: rcar_gen4_ptp: Move address assignment Niklas Söderlund
2026-02-01 18:37 ` [net-next 2/4] net: ethernet: renesas: rcar_gen4_ptp: Add helper to get clock index Niklas Söderlund
2026-02-01 18:37 ` [net-next 3/4] net: ethernet: renesas: rcar_gen4_ptp: Add helper to read time Niklas Söderlund
2026-02-01 18:37 ` [net-next 4/4] net: ethernet: renesas: rcar_gen4_ptp: Hide private data from users Niklas Söderlund
2026-02-03 3:11 ` Jakub Kicinski [this message]
2026-02-03 6:39 ` Niklas Söderlund
2026-02-04 3:50 ` [net-next 0/4] net: ethernet: renesas: rcar_gen4_ptp: Hide private data patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202191121.71326ca2@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.