From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: Chris Snook <chris.snook@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk> (maintainer:SFF/SFP/SFP+
MODULE SUPPORT:Keyword:phylink\.h|struct\s+phylink|\.phylink|>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net 2/3] Revert "net: ag71xx: remove platform_set_drvdata"
Date: Mon, 2 Feb 2026 13:46:33 -0800 [thread overview]
Message-ID: <20260202214634.72738-2-rosenp@gmail.com> (raw)
In-Reply-To: <20260202214634.72738-1-rosenp@gmail.com>
This reverts commit 94656823c1ac31b35549fc0d96cd7862254e7c3d.
platform_set_drvdata is needed in order to destroy phylink on platform
device removal.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/atheros/ag71xx.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index f2f12642529e..7114f2970ac6 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -1921,6 +1921,8 @@ static int ag71xx_probe(struct platform_device *pdev)
if (err)
return err;
+ platform_set_drvdata(pdev, ndev);
+
err = ag71xx_phylink_setup(ag);
if (err)
return dev_err_probe(&pdev->dev, err,
@@ -1929,6 +1931,7 @@ static int ag71xx_probe(struct platform_device *pdev)
err = register_netdev(ndev);
if (err) {
netif_err(ag, probe, ndev, "unable to register net device\n");
+ platform_set_drvdata(pdev, NULL);
return err;
}
@@ -2035,7 +2038,7 @@ MODULE_DEVICE_TABLE(of, ag71xx_match);
static struct platform_driver ag71xx_driver = {
.probe = ag71xx_probe,
- .remove_new = ag71xx_remove,
+ .remove = ag71xx_remove,
.driver = {
.name = "ag71xx",
.of_match_table = ag71xx_match,
--
2.52.0
next prev parent reply other threads:[~2026-02-02 21:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 21:46 [PATCH net 1/3] Revert "net: ag71xx: use devm for register_netdev" Rosen Penev
2026-02-02 21:46 ` Rosen Penev [this message]
2026-02-02 21:46 ` [PATCH net 3/3] net: ag71xx: call phylink_destroy on failure Rosen Penev
2026-02-04 3:32 ` Jakub Kicinski
2026-02-03 10:28 ` [PATCH net 1/3] Revert "net: ag71xx: use devm for register_netdev" Bartosz Golaszewski
2026-02-03 19:52 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202214634.72738-2-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.