From: Kevin Hao <haokexin@gmail.com>
To: netdev@vger.kernel.org
Cc: Kevin Hao <haokexin@gmail.com>,
stable@vger.kernel.org, Siddharth Vadapalli <s-vadapalli@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
linux-omap@vger.kernel.org
Subject: [PATCH net v5 0/2] net: cpsw: Execute ndo_set_rx_mode callback in a work queue
Date: Tue, 03 Feb 2026 10:18:29 +0800 [thread overview]
Message-ID: <20260203-bbb-v5-0-ea0ea217a85c@gmail.com> (raw)
These two patches resolve an RTNL assertion call trace issue in both the legacy
and new cpsw drivers.
Thanks,
Kevin
---
Changes in v5:
- Apply the same fix to the legacy cpsw driver as well.
- Use goto label in cpsw_ndo_set_rx_mode_work() for the undo path as
suggested by Jakub.
- Move the disable_work_sync() call to after unregister_netdev() as
suggested by Jakub.
- Link to v4: https://lore.kernel.org/r/20260130-bbb-v4-1-2bd000a15c34@gmail.com
Changes in v4:
- Using schedule_work() instead of creating a dedicated workqueue.
- Link to v3: https://lore.kernel.org/r/20260127-bbb-v3-1-5e71f340c1e9@gmail.com
Changes in v3:
- Resolve the deadlock issue identified in the AI review [2]
by moving the netif_running() check under the RTNL lock and removing the
cancel_work_sync() call in cpsw_ndo_stop().
- Link to v2: https://lore.kernel.org/r/20260125-bbb-v2-1-1547ffabc9d3@gmail.com
Changes in v2:
- Addresses the issue identified in the AI review [1]:
- Adds a netif_running() check in cpsw_ndo_set_rx_mode_work()
- Cancels the rx_mode_work in cpsw_ndo_stop()
- Link to v1: https://lore.kernel.org/r/20260123-bbb-v1-1-176b0b71834d@gmail.com
[1] https://netdev-ai.bots.linux.dev/ai-review.html?id=bd885e1e-1aed-4755-ad60-7150737ad0f5
[2] https://netdev-ai.bots.linux.dev/ai-review.html?id=c9fc3cf8-a06c-4cb8-b26b-910e775951a0
---
Kevin Hao (2):
net: cpsw_new: Execute ndo_set_rx_mode callback in a work queue
net: cpsw: Execute ndo_set_rx_mode callback in a work queue
drivers/net/ethernet/ti/cpsw.c | 41 +++++++++++++++++++++++++++++++------
drivers/net/ethernet/ti/cpsw_new.c | 34 +++++++++++++++++++++++++-----
drivers/net/ethernet/ti/cpsw_priv.h | 1 +
3 files changed, 65 insertions(+), 11 deletions(-)
---
base-commit: 193579fe01389bc21aff0051d13f24e8ea95b47d
change-id: 20260123-bbb-dc3675f671d0
Best regards,
--
Kevin Hao <haokexin@gmail.com>
next reply other threads:[~2026-02-03 2:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 2:18 Kevin Hao [this message]
2026-02-03 2:18 ` [PATCH net v5 1/2] net: cpsw_new: Execute ndo_set_rx_mode callback in a work queue Kevin Hao
2026-02-03 2:18 ` [PATCH net v5 2/2] net: cpsw: " Kevin Hao
2026-02-04 3:50 ` [PATCH net v5 0/2] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203-bbb-v5-0-ea0ea217a85c@gmail.com \
--to=haokexin@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=stable@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.