From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 312403EBF0C for ; Tue, 3 Feb 2026 00:59:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770080356; cv=none; b=Ma//Y0RNI5wL455VmfDez8jRJm5B6UJXIVzojd9bBk118KUoinSCw216KOeel+oZRhv58jPX3qe8GKO3DZrgaRfGW/M0r35Zs+YgeOLrWukXlNikE4DRTk27IT21xvxuP3g1RFkX/lh73fHJ/zIQR7dT9h1ZQNKU3738jLvTKP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770080356; c=relaxed/simple; bh=8248i/kYArgyaQTa2HABl7HpWtk+x6i4SNBHC7ecfvw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YG2eIydw0P3WpBwYo/WHZ3nSFZJ2Qgx92t7sqF6hjLYTlgK4+16DrxDFwz1bra2E5rcyC172BCGHnU+7bIbj00c0+2imlrWE4oOulFrQseLJ6pK18m8fVHuXyvGsQIRG0/qC/wx+p6jtI5/NLubKi6D+8Xu0KCqiNxqEtFKdNZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=oymjkyAL; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="oymjkyAL" Received: from macsyma.thunk.org (pool-173-48-123-50.bstnma.fios.verizon.net [173.48.123.50]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 6130wZeK027056 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 2 Feb 2026 19:58:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1770080319; bh=aUyJiVznOTfQ6pPxpOeT0GU34DTIGGka4AHQzI4bQCY=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=oymjkyALcY2L6SOAuZbHGBaaZnFauHrclv6xQuVdOYpduatevDy6DEZzen76pSw5N XSQfkThuW5BRzrU06IYhabSdIPWNjwnQq3+jhdRbr25SpUVdQmkk5lNGOzd/uO747K 5wJy84oHudJlo887rgejCF0q1QH5M51Hm5HrX5Qs3lHCepH4V3tn4Q2Mbopst+Bthx 0C+l4IQPlMxaV2LUrSt8VQhwr0E8xmYuMjg6fdD9CnZNtwd7fmd+npl3qZ/la1AxRO KtkMvAXtqMqtkMjomn3aBlwVAqM9ZppQSr3aAmTcLg/UvUvgBZF6yKRoZrRsiGt2QT gDbA0NuZCVYXw== Received: by macsyma.thunk.org (Postfix, from userid 15806) id F2B815704A33; Mon, 2 Feb 2026 19:57:34 -0500 (EST) Date: Mon, 2 Feb 2026 19:57:34 -0500 From: "Theodore Tso" To: Christoph Hellwig Cc: Eric Biggers , Al Viro , Christian Brauner , Jan Kara , David Sterba , Jaegeuk Kim , Chao Yu , Andrey Albershteyn , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev Subject: Re: [PATCH 03/11] ext4: move ->read_folio and ->readahead to readahead.c Message-ID: <20260203005734.GB31420@macsyma.lan> References: <20260202060754.270269-1-hch@lst.de> <20260202060754.270269-4-hch@lst.de> Precedence: bulk X-Mailing-List: fsverity@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260202060754.270269-4-hch@lst.de> On Mon, Feb 02, 2026 at 07:06:32AM +0100, Christoph Hellwig wrote: > Keep all the read into pagecache code in a single file. > > Signed-off-by: Christoph Hellwig Makes sense to me. Thanks, Acked-by: Theodore Ts'o From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48C30E7FDF3 for ; Tue, 3 Feb 2026 00:59:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=00uLnF3p4eL+4msJ8U+Zme+4dTC86uZhWzVLIW5q1Nk=; b=dCh3vupD/pixrJQqmYX2NcBQVj FNRWzi2TpsQHy2wYKgg2R54lwefP6tWfaYCqWOp51M92ulArPlZocxEErLarQ85vKSQcKgWFvKCmd 7NluJuORWZmxbAzYwoQC9qtwaATKVBLtD+A7HodgNngs3y5t21C7dUQo9FSl98KyPCQU=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vn4lN-00018l-BQ; Tue, 03 Feb 2026 00:59:29 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vn4lL-00018V-O5 for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Feb 2026 00:59:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aUyJiVznOTfQ6pPxpOeT0GU34DTIGGka4AHQzI4bQCY=; b=Q6yQL/txUCiGWagBJxLFo0Skw9 jJegiOJJQhj1DF2qv9tUoUtFI2rPHkfeAhcftgJa8RfK8cyhguHnW8JmZx98UZy1DeV89td901G3d wBR4j6uEk1m3rhR+we1qTXbbGurfLDAHsceldMX2Eo4hClxHT35dEuqxeg0PmCH6YvwA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aUyJiVznOTfQ6pPxpOeT0GU34DTIGGka4AHQzI4bQCY=; b=RGKlfKVoDQRfkjh8/XVIJSfdxy YgkEmEDYn9jIe+0I50eq7uEp4LOr6u1UB+vnxpLyyASTXjMVg+XrCFBNI9iAhHeRXG+pT5lzHs/P5 SQz05dgwQHvwMbytkbAuEMZjsix7zvmt6sf3XyKUAtDdtnLJbWKTPaWfNHNA6GmkcG98=; Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vn4lL-0007a9-75 for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Feb 2026 00:59:27 +0000 Received: from macsyma.thunk.org (pool-173-48-123-50.bstnma.fios.verizon.net [173.48.123.50]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 6130wZeK027056 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 2 Feb 2026 19:58:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1770080319; bh=aUyJiVznOTfQ6pPxpOeT0GU34DTIGGka4AHQzI4bQCY=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=oymjkyALcY2L6SOAuZbHGBaaZnFauHrclv6xQuVdOYpduatevDy6DEZzen76pSw5N XSQfkThuW5BRzrU06IYhabSdIPWNjwnQq3+jhdRbr25SpUVdQmkk5lNGOzd/uO747K 5wJy84oHudJlo887rgejCF0q1QH5M51Hm5HrX5Qs3lHCepH4V3tn4Q2Mbopst+Bthx 0C+l4IQPlMxaV2LUrSt8VQhwr0E8xmYuMjg6fdD9CnZNtwd7fmd+npl3qZ/la1AxRO KtkMvAXtqMqtkMjomn3aBlwVAqM9ZppQSr3aAmTcLg/UvUvgBZF6yKRoZrRsiGt2QT gDbA0NuZCVYXw== Received: by macsyma.thunk.org (Postfix, from userid 15806) id F2B815704A33; Mon, 2 Feb 2026 19:57:34 -0500 (EST) Date: Mon, 2 Feb 2026 19:57:34 -0500 From: "Theodore Tso" To: Christoph Hellwig Message-ID: <20260203005734.GB31420@macsyma.lan> References: <20260202060754.270269-1-hch@lst.de> <20260202060754.270269-4-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260202060754.270269-4-hch@lst.de> X-Headers-End: 1vn4lL-0007a9-75 Subject: Re: [f2fs-dev] [PATCH 03/11] ext4: move ->read_folio and ->readahead to readahead.c X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fsverity@lists.linux.dev, Christian Brauner , Jan Kara , Andrey Albershteyn , Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fsdevel@vger.kernel.org, Al Viro , David Sterba , Jaegeuk Kim , linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Feb 02, 2026 at 07:06:32AM +0100, Christoph Hellwig wrote: > Keep all the read into pagecache code in a single file. > > Signed-off-by: Christoph Hellwig Makes sense to me. Thanks, Acked-by: Theodore Ts'o _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel