From: Al Viro <viro@zeniv.linux.org.uk>
To: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Cc: "glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
"shardulsb08@gmail.com" <shardulsb08@gmail.com>,
"slava@dubeyko.com" <slava@dubeyko.com>,
"frank.li@vivo.com" <frank.li@vivo.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"shardul.b@mpiricsoftware.com" <shardul.b@mpiricsoftware.com>,
"jack@suse.cz" <jack@suse.cz>,
"janak@mpiricsoftware.com" <janak@mpiricsoftware.com>,
"brauner@kernel.org" <brauner@kernel.org>,
"syzbot+99f6ed51479b86ac4c41@syzkaller.appspotmail.com"
<syzbot+99f6ed51479b86ac4c41@syzkaller.appspotmail.com>
Subject: Re: [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure
Date: Tue, 3 Feb 2026 04:38:06 +0000 [thread overview]
Message-ID: <20260203043806.GF3183987@ZenIV> (raw)
In-Reply-To: <cace4df975e1ae6e31af0103efcbca9cdb8b8350.camel@ibm.com>
On Mon, Feb 02, 2026 at 05:53:57PM +0000, Viacheslav Dubeyko wrote:
> > out_unload_nls:
> > - unload_nls(sbi->nls);
^^^^^^^^^^^^^^^^^^^^
> > unload_nls(nls);
> > - kfree(sbi);
> The patch [1] fixes the issue and it in HFS/HFS+ tree already.
AFAICS, [1] lacks this removal of unload_nls() on failure exit.
IOW, the variant in your tree does unload_nls(sbi->nls) twice...
next prev parent reply other threads:[~2026-02-03 4:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 13:12 [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure Shardul Bankar
2026-02-02 17:53 ` Viacheslav Dubeyko
2026-02-03 4:38 ` Al Viro [this message]
2026-02-03 23:35 ` Viacheslav Dubeyko
2026-02-04 4:19 ` Shardul Bankar
2026-02-04 17:04 ` [PATCH] hfsplus: avoid double unload_nls() on mount failure Shardul Bankar
2026-02-05 23:08 ` Viacheslav Dubeyko
2026-02-04 17:30 ` [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure Al Viro
2026-02-04 17:40 ` Al Viro
2026-02-04 17:52 ` Al Viro
2026-02-04 18:25 ` Al Viro
2026-02-04 23:04 ` Viacheslav Dubeyko
2026-02-06 22:22 ` Viacheslav Dubeyko
2026-02-11 2:03 ` Al Viro
2026-02-11 23:49 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203043806.GF3183987@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=Slava.Dubeyko@ibm.com \
--cc=brauner@kernel.org \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jack@suse.cz \
--cc=janak@mpiricsoftware.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shardul.b@mpiricsoftware.com \
--cc=shardulsb08@gmail.com \
--cc=slava@dubeyko.com \
--cc=syzbot+99f6ed51479b86ac4c41@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.