From: Christoph Hellwig <hch@lst.de>
To: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: cleanup inode counter stats
Date: Tue, 3 Feb 2026 07:47:43 +0100 [thread overview]
Message-ID: <20260203064743.GA18484@lst.de> (raw)
In-Reply-To: <cd435a8cf4f29d2b979b025c56de898f439c649a.camel@gmail.com>
On Tue, Feb 03, 2026 at 11:46:41AM +0530, Nirjhar Roy (IBM) wrote:
> On Mon, 2026-02-02 at 15:14 +0100, Christoph Hellwig wrote:
> > Most of the are unused, so mark them as such. Give the remaining ones
>
> Nit - Typo - "Most of the are <...>" -> "Most of them are <...>"
Yes, thanks.
> > + uint32_t xs_inodes_active;
> > + uint32_t __unused_vn_alloc;
> > + uint32_t __unused_vn_get;
> > + uint32_t __unused_vn_hold;
> Any reason to keep the unused field?
If we drop the unused fields the sysfs output would change.
next prev parent reply other threads:[~2026-02-03 6:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 14:14 fix inode stats with lots of metafiles Christoph Hellwig
2026-02-02 14:14 ` [PATCH 1/2] xfs: cleanup inode counter stats Christoph Hellwig
2026-02-03 6:16 ` Nirjhar Roy (IBM)
2026-02-03 6:47 ` Christoph Hellwig [this message]
2026-02-06 6:38 ` Darrick J. Wong
2026-02-02 14:14 ` [PATCH 2/2] xfs: remove metafile inodes from the active inode stat Christoph Hellwig
2026-02-03 7:11 ` Nirjhar Roy (IBM)
2026-02-03 7:14 ` Christoph Hellwig
2026-02-03 7:24 ` Nirjhar Roy (IBM)
2026-02-03 7:29 ` Christoph Hellwig
2026-02-06 6:43 ` Darrick J. Wong
2026-02-06 6:52 ` Christoph Hellwig
2026-02-25 9:38 ` fix inode stats with lots of metafiles Carlos Maiolino
-- strict thread matches above, loose matches on Subject: below --
2026-02-24 13:59 fix inode stats with lots of metafiles v2 Christoph Hellwig
2026-02-24 13:59 ` [PATCH 1/2] xfs: cleanup inode counter stats Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203064743.GA18484@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nirjhar.roy.lists@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.