From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 3/3] tcp: make tcp_v{4,6}_send_check() static
Date: Tue, 3 Feb 2026 09:26:36 -0800 [thread overview]
Message-ID: <20260203092636.20c6bb6e@kernel.org> (raw)
In-Reply-To: <20260203144053.83193-4-edumazet@google.com>
On Tue, 3 Feb 2026 14:40:53 +0000 Eric Dumazet wrote:
> tcp_v{4,6}_send_check() are only called from tcp_output.c
> and should be made static so that the compiler does not need
> to put an out of line copy of them.
>
> Remove (struct inet_connection_sock_af_ops) send_check field
> and use instead @net_header_len.
>
> Move @net_header_len close to @queue_xmit for data locality
> as both are used in TCP tx fast path.
Seeing this in allmodconfig:
net/ipv4/tcp_output.c:1482:13: warning: unused function 'tcp_v4_send_check' [-Wunused-function]
1482 | static void tcp_v4_send_check(struct sock *sk, struct sk_buff *skb)
| ^~~~~~~~~~~~~~~~~
--
pw-bot: cr
next prev parent reply other threads:[~2026-02-03 17:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 14:40 [PATCH net-next 0/3] tcp: rework tcp_v{4,6}_send_check() Eric Dumazet
2026-02-03 14:40 ` [PATCH net-next 1/3] tcp: inline __tcp_v4_send_check() Eric Dumazet
2026-02-03 14:40 ` [PATCH net-next 2/3] tcp: move tcp_v6_send_check() to tcp_output.c Eric Dumazet
2026-02-09 5:10 ` kernel test robot
2026-02-03 14:40 ` [PATCH net-next 3/3] tcp: make tcp_v{4,6}_send_check() static Eric Dumazet
2026-02-03 17:26 ` Jakub Kicinski [this message]
2026-02-03 18:18 ` Eric Dumazet
2026-02-10 14:09 ` Eric Dumazet
2026-02-03 19:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203092636.20c6bb6e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.