From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] net: add vlan_get_protocol_offset_inline() helper
Date: Tue, 3 Feb 2026 19:17:40 -0800 [thread overview]
Message-ID: <20260203191740.2404d44c@kernel.org> (raw)
In-Reply-To: <20260202082200.650516-1-edumazet@google.com>
On Mon, 2 Feb 2026 08:22:00 +0000 Eric Dumazet wrote:
> +struct type_depth {
> + __be16 type;
> + u16 depth;
> +};
Should we prefix the struct name with vlan_
Seeing type_depth made me think the function is returning some compiler
metadata :S Maybe it's just me.
next prev parent reply other threads:[~2026-02-04 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 8:22 [PATCH net-next] net: add vlan_get_protocol_offset_inline() helper Eric Dumazet
2026-02-03 20:14 ` Simon Horman
2026-02-04 3:17 ` Jakub Kicinski [this message]
2026-02-04 5:06 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203191740.2404d44c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.