From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01F6B2D94AF for ; Tue, 3 Feb 2026 11:48:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770119324; cv=none; b=O0TtF0PJijDabPHAx37iNWYy4oGr5O2CjoxaOTE3mrTYD0+hdKxk41RMyHy9R+4VFYy0CuPE1rE2c39gPYAaUEz4Z1XJgZfnvVGnqRRc80A69hGwfg3+gu/qyjkrp+bY1k99USls0aw4vIblb4ImOVZa2OXAx2Zjlu2HpJCJaGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770119324; c=relaxed/simple; bh=Pq01T82q53EuPq8R6PNDRKUDIKHx0qvGXHvKD90zTNA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SZ6sr3jussdX+g0YIKhijEeg/ElWE3r2LHLJsWgF3ldHHqWBh8Z0kNDq75+A2g42+OaABlVdP18JrW5deSxlgk7FBudJMraTav22hCmz4Jg61lWPg31ygd6EcpTDo3D7ZrWUUoxlRhnVP5gj+EMaehtE+I2/NFcBi0quL1cJCZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=osnCPB8r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="osnCPB8r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FB25C116D0; Tue, 3 Feb 2026 11:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1770119323; bh=Pq01T82q53EuPq8R6PNDRKUDIKHx0qvGXHvKD90zTNA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=osnCPB8rtAcRhZ9k+xa1sljHFR+2rA8b9pNT07rWp9VM1e3G3v9fSvpsIiMQS4/CK nqA/3IyFu5zU9thlMC4CKq5jnze3Sw6bmf0S98o8P2i8SaiXbNRIGU5X3nZ8vxYMGh 08b3nMRRZ23NRZXX3uJpH1/sVYOL8bvU9PP+6y+A= Date: Tue, 3 Feb 2026 12:48:40 +0100 From: Greg Kroah-Hartman To: Alice Ryhl Cc: Carlos Llamas , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node() Message-ID: <2026020323-oversold-goon-b522@gregkh> References: <20260128-binder-fix-target-node-null-v1-1-78d198ef55a5@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128-binder-fix-target-node-null-v1-1-78d198ef55a5@google.com> On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote: > Somehow this got changed to NULL when I ported this to upstream it. No > idea how that happened. > > Reported-by: Carlos Llamas > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint") > Signed-off-by: Alice Ryhl > --- > Commit not yet upstream, so cc stable not required. > --- > drivers/android/binder/rust_binder.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644 > --- a/drivers/android/binder/rust_binder.h > +++ b/drivers/android/binder/rust_binder.h > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t > > if (p) > p = p + RUST_BINDER_LAYOUT.n.arc_offset; > - return NULL; > + return p; > } > > static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t) > > --- > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200 Does not apply at all, what tree was this made against? thanks, greg k-h