From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: Carlos Llamas <cmllamas@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust_binder: return p from rust_binder_transaction_target_node()
Date: Tue, 3 Feb 2026 12:57:05 +0100 [thread overview]
Message-ID: <2026020354-skeleton-marina-39c4@gregkh> (raw)
In-Reply-To: <2026020323-oversold-goon-b522@gregkh>
On Tue, Feb 03, 2026 at 12:48:40PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 28, 2026 at 09:12:07AM +0000, Alice Ryhl wrote:
> > Somehow this got changed to NULL when I ported this to upstream it. No
> > idea how that happened.
> >
> > Reported-by: Carlos Llamas <cmllamas@google.com>
> > Closes: https://lore.kernel.org/r/aXkEiC1sGOGfDuzI@google.com
> > Fixes: c1ea31205edf ("rust_binder: add binder_transaction tracepoint")
> > Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> > ---
> > Commit not yet upstream, so cc stable not required.
> > ---
> > drivers/android/binder/rust_binder.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/android/binder/rust_binder.h b/drivers/android/binder/rust_binder.h
> > index e68ba7a23c34de4688fa7d34341b0585b5dba7e9..d2284726c025190415239acfa07728caa814d260 100644
> > --- a/drivers/android/binder/rust_binder.h
> > +++ b/drivers/android/binder/rust_binder.h
> > @@ -79,7 +79,7 @@ static inline rust_binder_node rust_binder_transaction_target_node(rust_binder_t
> >
> > if (p)
> > p = p + RUST_BINDER_LAYOUT.n.arc_offset;
> > - return NULL;
> > + return p;
> > }
> >
> > static inline rust_binder_process rust_binder_transaction_to_proc(rust_binder_transaction t)
> >
> > ---
> > base-commit: e94865ca2340e9eaec08716dfad645e9f719eedd
> > change-id: 20260128-binder-fix-target-node-null-02fcb98f0200
>
> Does not apply at all, what tree was this made against?
Ugh, I was looking at the wrong tree, nevermind, my fault...
greg k-h
prev parent reply other threads:[~2026-02-03 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 9:12 [PATCH] rust_binder: return p from rust_binder_transaction_target_node() Alice Ryhl
2026-01-28 13:53 ` Carlos Llamas
2026-02-03 11:48 ` Greg Kroah-Hartman
2026-02-03 11:56 ` Alice Ryhl
2026-02-03 12:10 ` Greg Kroah-Hartman
2026-02-03 11:57 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026020354-skeleton-marina-39c4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aliceryhl@google.com \
--cc=cmllamas@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.