From: Stephen Hemminger <stephen@networkplumber.org>
To: Yehor Malikov <malikovyehor@gmail.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, chenbox@nvidia.com,
Yehor Malikov <Yehor.Malikov@solidigm.com>
Subject: Re: [PATCH v3] vhost: fix use-after-free in fdset during shutdown
Date: Wed, 4 Feb 2026 12:34:24 -0800 [thread overview]
Message-ID: <20260204123424.6ff763cc@phoenix.local> (raw)
In-Reply-To: <20260204185800.9299-1-malikovyehor@gmail.com>
On Wed, 4 Feb 2026 19:58:00 +0100
Yehor Malikov <malikovyehor@gmail.com> wrote:
> + /* Remove from global fdsets list */
> + pthread_mutex_lock(&fdsets_mutex);
> + for (i = 0; i < MAX_FDSETS; i++) {
> + if (fdsets[i] == pfdset) {
> + fdsets[i] = NULL;
> + break;
> + }
> + }
> + pthread_mutex_unlock(&fdsets_mutex);
> +
> + /* Free the fdset */
> + rte_free(pfdset);
> +}
> +
Calling mutex_lock in destructor seems it could be a problem.
Also, I would put in a destructor unless the init was called
by a constructor.
next prev parent reply other threads:[~2026-02-04 20:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 18:03 [PATCH] vhost: fix use-after-free in fdset during shutdown Yehor Malikov
2026-02-04 18:48 ` [PATCH v2] " malikovyehor
2026-02-04 18:58 ` [PATCH v3] " Yehor Malikov
2026-02-04 20:34 ` Stephen Hemminger [this message]
2026-02-04 21:32 ` Yehor Malikov
2026-02-04 21:35 ` [PATCH v4] " Yehor Malikov
2026-02-04 22:00 ` [PATCH v5] " Yehor Malikov
2026-02-04 23:05 ` [PATCH v6] " Yehor Malikov
2026-02-05 1:17 ` Stephen Hemminger
2026-02-05 11:16 ` [PATCH v7] " Yehor Malikov
2026-02-05 11:20 ` Yehor Malikov
2026-02-05 18:30 ` [PATCH v8] " Yehor Malikov
2026-02-05 18:35 ` [PATCH v9] " Yehor Malikov
2026-02-16 10:17 ` Yehor Malikov
2026-02-17 14:31 ` David Marchand
2026-02-18 7:50 ` [PATCH v10] " Yehor Malikov
2026-02-18 8:01 ` [PATCH v11] " Yehor Malikov
2026-02-18 8:52 ` David Marchand
2026-02-18 9:05 ` [PATCH v12] " Yehor Malikov
2026-02-18 10:27 ` David Marchand
2026-02-27 9:00 ` fengchengwen
2026-03-05 10:50 ` Maxime Coquelin
2026-03-05 13:52 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204123424.6ff763cc@phoenix.local \
--to=stephen@networkplumber.org \
--cc=Yehor.Malikov@solidigm.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=malikovyehor@gmail.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.