All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v4] devtools: replace checkpatches shell wrapper with Python script
Date: Wed, 4 Feb 2026 17:43:45 -0800	[thread overview]
Message-ID: <20260204174345.06352357@phoenix.local> (raw)
In-Reply-To: <aYOCr5S3USrer0vp@bricha3-mobl1.ger.corp.intel.com>

On Wed, 4 Feb 2026 17:32:31 +0000
Bruce Richardson <bruce.richardson@intel.com> wrote:

> On Wed, Feb 04, 2026 at 08:59:17AM -0800, Stephen Hemminger wrote:
> > Alternative to the checkpatches.sh shell script that wraps the Linux kernel's
> > checkpatch.pl with a standalone Python implementation. The new
> > dpdk-checkpatch.py script provides equivalent functionality without
> > requiring the kernel source tree or Perl.
> > 
> > Performance is significantly improved: checking a recent flow parser
> > patch series dropped from 2m23s to 0.43s (approximately 300x faster).
> >   
> Yep, it is definitely a LOT faster. Running on top 10 commits on main tree
> with old and new script:
> 
> $ time ./devtools/checkpatches.sh -n10
> 
> 10/10 valid patches
> 
> real	0m32.570s
> user	0m30.517s
> sys	0m2.256s
> 
> 
> $ time ./devtools/dpdk-checkpatch.py -n10
> 
> 10/10 valid patches
> 
> real	0m0.255s
> user	0m0.214s
> sys	0m0.040s
> 
> 32.5 seconds down to a quarter of a second is a massive gain. Looking
> forward to switching script for checking patches in future!
> 
> /Bruce

I still am finding some unintentional differences but it much
easier to fix false positives than in old code.

  reply	other threads:[~2026-02-05  1:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-31 20:48 [RFC] devtools: replace get-maintainer shell wrapper with Python script Stephen Hemminger
2026-02-01 13:51 ` Thomas Monjalon
2026-02-01 19:01   ` Stephen Hemminger
2026-02-01 20:16     ` Thomas Monjalon
2026-02-01 22:23       ` Stephen Hemminger
2026-02-01 19:22 ` [RFC v2] devtools: replace checkpatches " Stephen Hemminger
2026-02-03 14:17 ` [RFC v3] " Stephen Hemminger
2026-02-04 16:59 ` [PATCH v4] " Stephen Hemminger
2026-02-04 17:29   ` Bruce Richardson
2026-02-04 17:32   ` Bruce Richardson
2026-02-05  1:43     ` Stephen Hemminger [this message]
2026-02-26 17:15 ` [PATCH v5] devtools: add Python-based patch style checker Stephen Hemminger
2026-03-24 14:48 ` [PATCH v6] " Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204174345.06352357@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.