All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Pavan Chebbi <pavan.chebbi@broadcom.com>
Cc: Michael Chan <michael.chan@broadcom.com>,
	davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch,
	andrew.gospodarek@broadcom.com
Subject: Re: [PATCH net 4/4] selftests: drv-net: rss_ctx: test RSS contexts persist after ifdown/up
Date: Wed, 4 Feb 2026 18:09:02 -0800	[thread overview]
Message-ID: <20260204180902.00918071@kernel.org> (raw)
In-Reply-To: <CALs4sv2c9QaRtrV-21YsRsGOkap5LnGPcqEnk9ELn3WcUocFOQ@mail.gmail.com>

On Wed, 4 Feb 2026 21:45:12 +0530 Pavan Chebbi wrote:
> > > +
> > > +    for ctx_id in ctx_ids:
> > > +        try:
> > > +            data = get_rss(cfg, context=ctx_id)
> > > +            _rss_key_check(cfg, data=data, context=ctx_id)
> > > +            persisted_contexts.append(ctx_id)
> > > +        except CmdExitFailure:
> > > +            missing_contexts.append(ctx_id)
> > > +            ksft_pr(f"Context {ctx_id} is missing after ifup")  
> >
> > You can use netlink to get them all
> >
> > ctxs = cfg.ethnl.rss_get({}, dump=True)  
> 
> Jakub, maybe it's a rookie question but I am having trouble getting
> the netlink call to work.
> Not sure if my analysis is right but it looks like I don't have the
> right schema..
> It appears like the decode does not ignore unsupported ethnl options?
> I always get the error:
> 
> # Error decoding 'input-xfrm' from 'rss'
> 
> with the below call stack:
> 
> # # Exception| Traceback (most recent call last):
> # # Exception|   File "/tmp/ksft-net-drv/net/lib/py/ksft.py", line
> 319, in ksft_run
> # # Exception|     func(*args)
> # # Exception|   File "/tmp/ksft-net-drv/drivers/net/hw/./rss_ctx.py",
> line 395, in test_rss_context_dump
> # # Exception|     ctxs = cfg.ethnl.rss_get({}, dump=True)
> # # Exception|   File
> "/tmp/ksft-net-drv/net/lib/ynl/pyynl/lib/ynl.py", line 1159, in _op
> # # Exception|     return self._ops(ops)[0]
> # # Exception|   File
> "/tmp/ksft-net-drv/net/lib/ynl/pyynl/lib/ynl.py", line 1146, in _ops
> # # Exception|     rsp_msg = self._decode(decoded.raw_attrs, op.attr_set.name)
> # # Exception|   File
> "/tmp/ksft-net-drv/net/lib/ynl/pyynl/lib/ynl.py", line 814, in _decode
> # # Exception|     decoded = self._decode_enum(decoded, attr_spec)
> # # Exception|   File
> "/tmp/ksft-net-drv/net/lib/ynl/pyynl/lib/ynl.py", line 672, in
> _decode_enum
> # # Exception|     value.add(self._get_enum_or_unknown(enum, i))
> # # Exception|   File
> "/tmp/ksft-net-drv/net/lib/ynl/pyynl/lib/ynl.py", line 662, in
> _get_enum_or_unknown
> # # Exception|     raise error
> # # Exception|   File
> "/tmp/ksft-net-drv/net/lib/ynl/pyynl/lib/ynl.py", line 657, in
> _get_enum_or_unknown
> # # Exception|     name = enum.entries_by_val[raw].name
> # # Exception| KeyError: 2
> 
> Do you think I am missing some config?

Ah! I think you run into what I recently fixed in net.
Could you try with 1c172febdf065375 cherry-picked to your tree?
It's sitting in net, hasn't reached net-next yet.
Sorry about that..

  reply	other threads:[~2026-02-05  2:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29  6:16 [PATCH net 0/4] bnxt_en: Fix RSS context and ntuple filter issues Michael Chan
2026-01-29  6:16 ` [PATCH net 1/4] bnxt_en: Fix RSS context delete logic Michael Chan
2026-01-29  6:16 ` [PATCH net 2/4] bnxt_en: Don't overload fw_vnic_id for RSS context's filters Michael Chan
2026-01-29  6:16 ` [PATCH net 3/4] bnxt_en: Fix deleting of Ntuple filters Michael Chan
2026-01-29  6:16 ` [PATCH net 4/4] selftests: drv-net: rss_ctx: test RSS contexts persist after ifdown/up Michael Chan
2026-01-29 20:19   ` Joe Damato
2026-01-29 23:58     ` Jakub Kicinski
2026-01-30  2:03   ` Jakub Kicinski
2026-01-30  3:52     ` Pavan Chebbi
2026-01-30  5:24     ` Pavan Chebbi
2026-01-30 16:09       ` Jakub Kicinski
2026-02-04 16:15     ` Pavan Chebbi
2026-02-05  2:09       ` Jakub Kicinski [this message]
2026-02-05  5:41         ` Pavan Chebbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204180902.00918071@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.