From: Jakub Kicinski <kuba@kernel.org>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: lorenzo@kernel.org, andrew+netdev@lunn.ch, pabeni@redhat.com,
vadim.fedorenko@linux.dev, davem@davemloft.net,
guwen@linux.alibaba.com, lulie@linux.alibaba.com,
hkallweit1@gmail.com, edumazet@google.com,
lukas.bulwahn@redhat.com, andrew@lunn.ch, dong100@mucse.com,
dust.li@linux.alibaba.com, netdev@vger.kernel.org
Subject: Re: [net-next,v25,4/6] eea: create/destroy rx,tx queues for netdevice open and stop
Date: Wed, 4 Feb 2026 18:33:52 -0800 [thread overview]
Message-ID: <20260204183352.00b248c4@kernel.org> (raw)
In-Reply-To: <1770256081.5424275-1-xuanzhuo@linux.alibaba.com>
On Thu, 5 Feb 2026 09:48:01 +0800 Xuan Zhuo wrote:
> Regarding this point, I did some experimentation and believe there are several
> issues. First, since request_irq requires passing the RX structure as callback
> data, we cannot reuse the same IRQ directly—we must first free the existing
> IRQ and then request a new one. To safely free an IRQ, the most reasonable
> approach is to stop the backend NIC's operations before releasing the IRQ. This
> constraint means we can only free the IRQ after tearing down the NIC. I've
> reviewed implementations of other NIC drivers, and they generally follow similar
> logic.
>
> Moreover, I believe it would be quite difficult to achieve this with only minor
> modifications. In the future, we might consider introducing a proxy or an
> intermediate structure to serve as the IRQ callback data, which could enable IRQ
> reuse. However, that would likely require more substantial changes. Given that
> we've already done extensive review and refinement, I'd prefer to avoid
> introducing major refactoring at this stage.
Please TAL at commit 3a856ab34726 ("eth: fbnic: add IRQ reuse support")
for inspiration?
next prev parent reply other threads:[~2026-02-05 2:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 9:06 [PATCH net-next v25 0/6] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor Xuan Zhuo
2026-02-02 9:06 ` [PATCH net-next v25 1/6] eea: introduce PCI framework Xuan Zhuo
2026-02-02 9:06 ` [PATCH net-next v25 2/6] eea: introduce ring and descriptor structures Xuan Zhuo
2026-02-02 9:06 ` [PATCH net-next v25 3/6] eea: probe the netdevice and create adminq Xuan Zhuo
2026-02-02 9:06 ` [PATCH net-next v25 4/6] eea: create/destroy rx,tx queues for netdevice open and stop Xuan Zhuo
2026-02-04 4:00 ` [net-next,v25,4/6] " Jakub Kicinski
2026-02-04 4:12 ` Jakub Kicinski
2026-02-04 11:46 ` Xuan Zhuo
2026-02-05 2:31 ` Jakub Kicinski
2026-02-05 1:48 ` Xuan Zhuo
2026-02-05 2:33 ` Jakub Kicinski [this message]
2026-02-02 9:06 ` [PATCH net-next v25 5/6] eea: introduce ethtool support Xuan Zhuo
2026-02-02 9:06 ` [PATCH net-next v25 6/6] eea: introduce callback for ndo_get_stats64 Xuan Zhuo
2026-02-04 4:08 ` [net-next,v25,6/6] " Jakub Kicinski
2026-02-04 4:13 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204183352.00b248c4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=hkallweit1@gmail.com \
--cc=lorenzo@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=lulie@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.