Re: [PATCH v11 09/30] tracing: Add events to trace remotes

[Steven Rostedt <rostedt@goodmis.org>]

On Sat, 31 Jan 2026 13:28:27 +0000
Vincent Donnefort <vdonnefort@google.com> wrote:

> @@ -487,16 +494,19 @@ __peek_event(struct trace_remote_iterator *iter, int cpu, u64 *ts, unsigned long
>  static bool trace_remote_iter_read_event(struct trace_remote_iterator *iter)
>  {
>  	struct trace_buffer *trace_buffer = iter->remote->trace_buffer;
> +	struct ring_buffer_event *rb_evt;
>  	int cpu = iter->cpu;
>  
>  	if (cpu != RING_BUFFER_ALL_CPUS) {
>  		if (ring_buffer_empty_cpu(trace_buffer, cpu))
>  			return false;
>  
> -		if (!__peek_event(iter, cpu, &iter->ts, &iter->lost_events))
> +		rb_evt = __peek_event(iter, cpu, &iter->ts, &iter->lost_events);
> +		if (!rb_evt)
>  			return false;
>  
>  		iter->evt_cpu = cpu;
> +		iter->evt = (struct remote_event_hdr *)ring_buffer_event_data(rb_evt);

BTW, you don't need to typecast the return of ring_buffer_event_data()
as that returns a void pointer.

>  		return true;
>  	}
>  
> @@ -508,7 +518,8 @@ static bool trace_remote_iter_read_event(struct trace_remote_iterator *iter)
>  		if (ring_buffer_empty_cpu(trace_buffer, cpu))
>  			continue;
>  
> -		if (!__peek_event(iter, cpu, &ts, &lost_events))
> +		rb_evt = __peek_event(iter, cpu, &ts, &lost_events);
> +		if (!rb_evt)
>  			continue;
>  
>  		if (ts >= iter->ts)
> @@ -516,6 +527,7 @@ static bool trace_remote_iter_read_event(struct trace_remote_iterator *iter)
>  
>  		iter->ts = ts;
>  		iter->evt_cpu = cpu;
> +		iter->evt = (struct remote_event_hdr *)ring_buffer_event_data(rb_evt);

ditto.

>  		iter->lost_events = lost_events;
>  	}
>  

Other than that...

Review-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve


> @@ -536,8 +548,11 @@ static void trace_remote_iter_move(struct trace_remote_iterator *iter)
>  	}
>  }
>