From: Jakub Kicinski <kuba@kernel.org>
To: Raju Rangoju <Raju.Rangoju@amd.com>
Cc: <netdev@vger.kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <davem@davemloft.net>,
<andrew+netdev@lunn.ch>, <linux-kernel@vger.kernel.org>,
<Shyam-sundar.S-k@amd.com>
Subject: Re: [PATCH net-next v3 0/4] amd-xgbe: add ARP offload and RSS self-tests
Date: Thu, 5 Feb 2026 19:09:04 -0800 [thread overview]
Message-ID: <20260205190904.78be3190@kernel.org> (raw)
In-Reply-To: <20260204145829.801839-1-Raju.Rangoju@amd.com>
On Wed, 4 Feb 2026 20:28:29 +0530 Raju Rangoju wrote:
> amd-xgbe: do not select NET_SELFTESTS when INET is disabled
I'll apply this one
> amd-xgbe: add hardware ARP offload support
> amd-xgbe: add ARP offload ethtool self-test
These two I don't get. The feature is enabled during the test but it
can't be enabled by a normal user. So what's the point of testing it?
> amd-xgbe: add RSS ethtool self-test
xgbe seems to implement Toeplitz hash, much better to run
tools/testing/selftests/drivers/net/hw/toeplitz.py
than just checking if the hash value != 0..
next prev parent reply other threads:[~2026-02-06 3:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 14:58 [PATCH net-next v3 0/4] amd-xgbe: add ARP offload and RSS self-tests Raju Rangoju
2026-02-06 3:09 ` Jakub Kicinski [this message]
2026-02-06 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205190904.78be3190@kernel.org \
--to=kuba@kernel.org \
--cc=Raju.Rangoju@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.