From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: [PATCH] devtools: fix indent in SPDX check
Date: Fri, 6 Feb 2026 09:36:49 +0100 [thread overview]
Message-ID: <20260206083649.2625478-1-david.marchand@redhat.com> (raw)
We have a mix of tabs and spaces.
Clean this up.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-spdx-tag.sh | 37 ++++++++++++++++++-------------------
1 file changed, 18 insertions(+), 19 deletions(-)
diff --git a/devtools/check-spdx-tag.sh b/devtools/check-spdx-tag.sh
index 2390941c74..a55d28581a 100755
--- a/devtools/check-spdx-tag.sh
+++ b/devtools/check-spdx-tag.sh
@@ -23,8 +23,8 @@ no_license_list=\
check_spdx() {
if $verbose ; then
- echo "Files without SPDX License"
- echo "--------------------------"
+ echo "Files without SPDX License"
+ echo "--------------------------"
fi
git grep -L SPDX-License-Identifier -- $no_license_list > $tmpfile
@@ -33,15 +33,15 @@ check_spdx() {
$quiet || cat $tmpfile
if $verbose ; then
- echo
- echo "Files with wrong SPDX format"
- echo "----------------------------"
+ echo
+ echo "Files with wrong SPDX format"
+ echo "----------------------------"
fi
files_without_spdx=$(cat $tmpfile)
git grep -LE '(/\*|#|;|\.\.) *SPDX-License-Identifier: [A-Z(]' -- $no_license_list > $tmpfile
for file in $files_without_spdx ; do
- sed -i "/^$file$/d" $tmpfile
+ sed -i "/^$file$/d" $tmpfile
done
warnings=$(($warnings + $(wc -l < $tmpfile)))
@@ -49,7 +49,7 @@ check_spdx() {
files_with_andor=$(git grep -lEi 'SPDX-License-Identifier:.*\<(AND|OR)\>' -- $no_license_list)
for file in $files_with_andor ; do
- grep -LE 'SPDX-License-Identifier:.*\<(AND|OR)\>' "$file"
+ grep -LE 'SPDX-License-Identifier:.*\<(AND|OR)\>' "$file"
done > $tmpfile
warnings=$(($warnings + $(wc -l < $tmpfile)))
@@ -67,8 +67,8 @@ build_exceptions_list() {
check_licenses() {
if $verbose ; then
- echo "Files with wrong license and no exception"
- echo "-----------------------------------------"
+ echo "Files with wrong license and no exception"
+ echo "-----------------------------------------"
fi
exceptions=$(build_exceptions_list)
@@ -81,24 +81,23 @@ check_licenses() {
check_boilerplate() {
if $verbose ; then
- echo "Files with redundant license text"
- echo "---------------------------------"
+ echo "Files with redundant license text"
+ echo "---------------------------------"
fi
- git grep -l Redistribution -- \
- ':^license/' ':^/devtools/check-spdx-tag.sh' > $tmpfile
+ git grep -l Redistribution -- ':^license/' ':^/devtools/check-spdx-tag.sh' > $tmpfile
warnings=$(($warnings + $(wc -l <$tmpfile)))
$quiet || cat $tmpfile
}
while getopts qvh ARG ; do
- case $ARG in
- q ) quiet=true ;;
- v ) verbose=true ;;
- h ) print_usage ; exit 0 ;;
- ? ) print_usage ; exit 1 ;;
- esac
+ case $ARG in
+ q ) quiet=true ;;
+ v ) verbose=true ;;
+ h ) print_usage ; exit 0 ;;
+ ? ) print_usage ; exit 1 ;;
+ esac
done
shift $(($OPTIND - 1))
--
2.52.0
next reply other threads:[~2026-02-06 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 8:36 David Marchand [this message]
2026-02-06 9:37 ` [PATCH] devtools: fix indent in SPDX check Thomas Monjalon
2026-02-06 9:41 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206083649.2625478-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.