From: "Łukasz Majewski" <lukasz.majewski@mailbox.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
Stefan Wahren <wahrenst@gmx.net>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [net-next v23 2/7] net: mtip: The L2 switch driver for imx287
Date: Fri, 6 Feb 2026 11:24:54 +0100 [thread overview]
Message-ID: <20260206112454.2e9a686f@wsk> (raw)
In-Reply-To: <20260205182805.196fd832@kernel.org>
Hi Jakub,
> On Thu, 5 Feb 2026 00:21:30 +0100 Lukasz Majewski wrote:
> > This patch series provides support for More Than IP L2 switch
> > embedded in the imx287 SoC.
> >
> > This is a two port switch (placed between uDMA[01] and MAC-NET[01]),
> > which can be used for offloading the network traffic.
> >
> > It can be used interchangeably with current FEC driver - to be more
> > specific: one can use either of it, depending on the requirements.
> >
> > The biggest difference is the usage of DMA - when FEC is used,
> > separate DMAs are available for each ENET-MAC block.
> > However, with switch enabled - only the DMA0 is used to
> > send/receive data to/form switch (and then switch sends them to
> > respecitive ports).
> >
> > Signed-off-by: Lukasz Majewski <lukasz.majewski@mailbox.org>
> > Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Transient build failure here:
>
> drivers/net/ethernet/freescale/mtipsw/mtipl2sw.c:1072:32: warning:
> variable ‘priv’ set but not used [-Wunused-but-set-variable] 1072 |
> struct mtip_ndev_priv *priv; |
> ^~~~
>
> I sent out the AI code reviews while at it, without looking at them.
> So please approach them with caution..
IMHO, issues pointed with AI review have been at discussed and
(to my best knowledge) addressed.
Shall I prepare next version of this patch set?
--
Best regards,
Łukasz Majewski
next prev parent reply other threads:[~2026-02-06 10:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 23:21 [net-next v23 0/7] net: mtip: Add support for MTIP imx287 L2 switch driver Lukasz Majewski
2026-02-04 23:21 ` [net-next v23 1/7] dt-bindings: net: Add MTIP L2 switch description Lukasz Majewski
2026-02-04 23:21 ` [net-next v23 2/7] net: mtip: The L2 switch driver for imx287 Lukasz Majewski
2026-02-06 2:26 ` [net-next,v23,2/7] " Jakub Kicinski
2026-02-06 2:28 ` [net-next v23 2/7] " Jakub Kicinski
2026-02-06 10:24 ` Łukasz Majewski [this message]
2026-02-16 9:23 ` Łukasz Majewski
2026-02-17 21:59 ` Jakub Kicinski
2026-02-04 23:21 ` [net-next v23 3/7] net: mtip: Add buffers management functions to the L2 switch driver Lukasz Majewski
2026-02-04 23:21 ` [net-next v23 4/7] net: mtip: Add net_device_ops " Lukasz Majewski
2026-02-06 2:26 ` [net-next,v23,4/7] " Jakub Kicinski
2026-02-04 23:21 ` [net-next v23 5/7] net: mtip: Add mtip_switch_{rx|tx} " Lukasz Majewski
2026-02-06 2:26 ` [net-next,v23,5/7] " Jakub Kicinski
2026-02-04 23:21 ` [net-next v23 6/7] net: mtip: Extend the L2 switch driver with management operations Lukasz Majewski
2026-02-04 23:21 ` [net-next v23 7/7] net: mtip: Extend the L2 switch driver for imx287 with bridge operations Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206112454.2e9a686f@wsk \
--to=lukasz.majewski@mailbox.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=horms@kernel.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.