All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@arm.com>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf record: Make logs more readable for event open failures
Date: Fri, 6 Feb 2026 16:32:22 +0000	[thread overview]
Message-ID: <20260206163222.GH3529712@e132581.arm.com> (raw)
In-Reply-To: <CAP-5=fUObi2ZoY60VF-WMD0=4=EB4e5s7SUAQyf3zoNA1my6Og@mail.gmail.com>

On Thu, Feb 05, 2026 at 02:33:04PM -0800, Ian Rogers wrote:
> On Thu, Feb 5, 2026 at 1:42 PM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > On Wed, Feb 04, 2026 at 09:29:14AM -0800, Ian Rogers wrote:
> > > On Wed, Feb 4, 2026 at 6:26 AM Leo Yan <leo.yan@arm.com> wrote:
> > > >
> > > > Since commit ee27476fa300 ("perf record: Skip don't fail for events that
> > > > don't open"), if a user does not have permission to access a PMU event,
> > > > perf reports:
> > > >
> > > >   perf record -e cs_etm// -C 3 -- ls
> > > >   Error:
> > > >   Failure to open event 'cs_etm//u' on PMU 'cs_etm' which will be removed.
> > > >   No fallback found for 'cs_etm//u' for error 13
> > > >   Error:
> > > >   Failure to open event 'dummy:u' on PMU 'software' which will be removed.
> > > >   No fallback found for 'dummy:u' for error 13
> > > >   Error:
> > > >   Failure to open any events for recording.
> > > >
> > > > The log is not very helpful, as no clear indication of what "error 13"
> > > > means or how to address the issue.
> > > >
> > > > This commit restores evsel__open_strerror() to generate a readable error
> > > > message and print it out:
> >
> > I'm applying this one, maybe we can at least suppress the one for dummy
> > when it is auto added?
> 
> IIRC it was left in as "perf record -e dummy" can be a way of just
> tracking sideband data and you'd want errors opening dummy to be
> warned upon in that case.

As Arnaldo said this patch has been picked, I sent a following patch
for simplifying the logs:
https://lore.kernel.org/linux-perf-users/20260206-perf_improve_log_for_open_event_failures-v1-1-366903bebcd7@arm.com/T/#u

If want me to resend two patches in a series, or squash into one,
please let me know.  Thanks!

Leo

      reply	other threads:[~2026-02-06 16:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 14:26 [PATCH] perf record: Make logs more readable for event open failures Leo Yan
2026-02-04 17:29 ` Ian Rogers
2026-02-05 10:30   ` Leo Yan
2026-02-05 17:07     ` Ian Rogers
2026-02-05 21:41   ` Arnaldo Carvalho de Melo
2026-02-05 22:33     ` Ian Rogers
2026-02-06 16:32       ` Leo Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260206163222.GH3529712@e132581.arm.com \
    --to=leo.yan@arm.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.