From: Niklas Cassel <cassel@kernel.org>
To: Jens Axboe <axboe@kernel.dk>, Vincent Fu <vincent.fu@samsung.com>
Cc: fio@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
Jorgen S Hansen <jorgen.hansen@wdc.com>,
Niklas Cassel <cassel@kernel.org>
Subject: [PATCH 0/3] fio: Avoid errno and errno string mismatch
Date: Fri, 6 Feb 2026 17:40:55 +0100 [thread overview]
Message-ID: <20260206164058.3105327-1-cassel@kernel.org> (raw)
Hello all,
This series fixes a problem where errno and error string representing that
errno could be out of sync.
Another possible solution is to remove td->verror everywhere and make sure
that the function wants the error string calls strerror() with the errno
when they actually need it. However, that would be a larger change.
Another optimization that could also be done is to look at the places where
we call update_error_count() and td_clear_error(), if we don't set
td->error for a non-fatal error, there is no reason to unconditionally call
td_clear_error() for a non-fatal error. (update_error_count() still has to
be called, as it sets td->first_error.) However, I do not really understand
why update_error_count() + td_clear_error() is called by both:
io_u.c:io_completed() and backend.c:break_on_this_error(), so I avoided to
do this optimization.
Niklas Cassel (3):
fio: Fix error string not matching errno
io_u: Fix inconsistent handling of non-fatal errors with option
error_dump
stat: Remove duplicate space in __show_run_stats()
fio.h | 7 +++----
io_u.c | 10 ++++++++--
stat.c | 2 +-
3 files changed, 12 insertions(+), 7 deletions(-)
--
2.53.0
next reply other threads:[~2026-02-06 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 16:40 Niklas Cassel [this message]
2026-02-06 16:40 ` [PATCH 1/3] fio: Fix error string not matching errno Niklas Cassel
2026-02-13 3:12 ` Damien Le Moal
2026-02-06 16:40 ` [PATCH 2/3] io_u: Fix inconsistent handling of non-fatal errors with option error_dump Niklas Cassel
2026-02-13 3:17 ` Damien Le Moal
2026-02-06 16:40 ` [PATCH 3/3] stat: Remove duplicate space in __show_run_stats() Niklas Cassel
2026-02-13 3:17 ` Damien Le Moal
2026-02-06 17:57 ` [PATCH 0/3] fio: Avoid errno and errno string mismatch fiotestbot
2026-02-14 2:39 ` Vincent Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206164058.3105327-1-cassel@kernel.org \
--to=cassel@kernel.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=fio@vger.kernel.org \
--cc=jorgen.hansen@wdc.com \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.