From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E8A2E78D4A for ; Mon, 9 Feb 2026 08:41:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 51E7A10E3A6; Mon, 9 Feb 2026 08:41:32 +0000 (UTC) Received: from MTA-08-4.privateemail.com (mta-08-4.privateemail.com [198.54.122.147]) by gabe.freedesktop.org (Postfix) with ESMTPS id D002910E15A; Sat, 7 Feb 2026 00:01:22 +0000 (UTC) Received: from mta-08.privateemail.com (localhost [127.0.0.1]) by mta-08.privateemail.com (Postfix) with ESMTP id 4f7B295Q7Cz3hhV1; Fri, 6 Feb 2026 19:01:21 -0500 (EST) Received: from localhost.localdomain (unknown [45.38.20.240]) by mta-08.privateemail.com (Postfix) with ESMTPA; Fri, 6 Feb 2026 19:00:46 -0500 (EST) From: Hamza Mahfooz To: dri-devel@lists.freedesktop.org Cc: =?UTF-8?q?Timur=20Krist=C3=B3f?= , =?UTF-8?q?Michel=20D=C3=A4nzer?= , Xaver Hugl , Hamza Mahfooz , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Ivan Lipski , Kenneth Feng , Alex Hung , Tom Chung , Melissa Wen , =?UTF-8?q?Michel=20D=C3=A4nzer?= , Fangzhi Zuo , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] drm: introduce KMS recovery mechanism Date: Fri, 6 Feb 2026 18:58:42 -0500 Message-ID: <20260206235846.1019172-1-someguy@effective-light.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-Mailman-Approved-At: Mon, 09 Feb 2026 08:41:30 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" There should be a mechanism for drivers to respond to flip_done timeouts. Since, as it stands it is possible for the display to stall indefinitely, necessitating a hard reset. So, introduce a new mechanism that tries various methods of recovery with increasing aggression, in the following order: 1. Force a full modeset (have the compositor reprogram the state from scratch). 3. As a last resort, have the driver attempt a vendor specific reset (assuming it provides an implementation to drm_crtc_funcs.page_flip_timeout()). Signed-off-by: Hamza Mahfooz --- v2: new to the series --- drivers/gpu/drm/drm_atomic_helper.c | 36 ++++++++++++++++++++++++++--- include/drm/drm_crtc.h | 9 ++++++++ include/drm/drm_device.h | 24 +++++++++++++++++++ 3 files changed, 66 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 5840e9cc6f66..f46d68418e32 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -1881,11 +1882,40 @@ void drm_atomic_helper_wait_for_flip_done(struct drm_device *dev, continue; ret = wait_for_completion_timeout(&commit->flip_done, 10 * HZ); - if (ret == 0) - drm_err(dev, "[CRTC:%d:%s] flip_done timed out\n", - crtc->base.id, crtc->name); + if (!ret) { + switch (dev->reset_phase) { + case DRM_KMS_RESET_NONE: + drm_err(dev, "[CRTC:%d:%s] flip_done timed out\n", + crtc->base.id, crtc->name); + dev->reset_phase = DRM_KMS_RESET_FORCE_MODESET; + drm_kms_helper_hotplug_event(dev); + break; + case DRM_KMS_RESET_FORCE_MODESET: + drm_err(dev, "[CRTC:%d:%s] force full modeset failed\n", + crtc->base.id, crtc->name); + dev->reset_phase = DRM_KMS_RESET_VENDOR; + if (crtc->funcs->page_flip_timeout) + crtc->funcs->page_flip_timeout(crtc); + break; + case DRM_KMS_RESET_VENDOR: + drm_err(dev, "[CRTC:%d:%s] KMS recovery failed!\n", + crtc->base.id, crtc->name); + dev->reset_phase = DRM_KMS_RESET_GIVE_UP; + break; + default: + break; + } + + goto exit; + } + } + + if (dev->reset_phase) { + drm_info(dev, "KMS recovery succeeded!\n"); + dev->reset_phase = DRM_KMS_RESET_NONE; } +exit: if (state->fake_commit) complete_all(&state->fake_commit->flip_done); } diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 66278ffeebd6..45dc5a76e915 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -609,6 +609,15 @@ struct drm_crtc_funcs { uint32_t flags, uint32_t target, struct drm_modeset_acquire_ctx *ctx); + /** + * @page_flip_timeout: + * + * This optional hook is called if &drm_crtc_commit.flip_done times out, + * and can be used by drivers to attempt to recover from a page flip + * timeout. + */ + void (*page_flip_timeout)(struct drm_crtc *crtc); + /** * @set_property: * diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h index bc78fb77cc27..1244d7527e7b 100644 --- a/include/drm/drm_device.h +++ b/include/drm/drm_device.h @@ -66,6 +66,23 @@ enum switch_power_state { DRM_SWITCH_POWER_DYNAMIC_OFF = 3, }; +/** + * enum drm_kms_reset_phase - reset phase of drm device + */ +enum drm_kms_reset_phase { + /** @DRM_KMS_RESET_NONE: Not currently attempting recovery */ + DRM_KMS_RESET_NONE, + + /** @DRM_KMS_RESET_FORCE_MODESET: Force a full modeset */ + DRM_KMS_RESET_FORCE_MODESET, + + /** @DRM_KMS_RESET_VENDOR: Attempt a vendor reset */ + DRM_KMS_RESET_VENDOR, + + /** @DRM_KMS_RESET_GIVE_UP: All recovery methods failed */ + DRM_KMS_RESET_GIVE_UP, +}; + /** * struct drm_device - DRM device structure * @@ -375,6 +392,13 @@ struct drm_device { * Root directory for debugfs files. */ struct dentry *debugfs_root; + + /** + * @reset_phase: + * + * Reset phase that the device is in. + */ + enum drm_kms_reset_phase reset_phase; }; void drm_dev_set_dma_dev(struct drm_device *dev, struct device *dma_dev); -- 2.52.0