All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Tzung-Bi Shih <tzungbi@kernel.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>, Shuah Khan <shuah@kernel.org>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Johan Hovold <johan@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	linux-kernel@vger.kernel.org, driver-core@lists.linux.dev,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] revocable: hide the implementation details from users
Date: Fri, 6 Feb 2026 16:08:18 +0100	[thread overview]
Message-ID: <2026020654-sadly-anchor-00bc@gregkh> (raw)
In-Reply-To: <20260206103216.38623-1-bartosz.golaszewski@oss.qualcomm.com>

On Fri, Feb 06, 2026 at 11:32:06AM +0100, Bartosz Golaszewski wrote:
> -struct revocable_provider __rcu *revocable_provider_alloc(void *res)
> +revocable_provider_t revocable_provider_alloc(void *res)

While I understand why you did this, and it does save us the "__rcu"
usage which is essencial, it still makes me feel dirty seeing it :)

Also, as the __rcu pointer is now "hidden", what is that going to mean
for sparse usage?  Will this accidentally trigger problems if we do
anything with the pointer incorrectly?

thanks,

greg k-h

  reply	other threads:[~2026-02-06 15:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 10:32 [PATCH] revocable: hide the implementation details from users Bartosz Golaszewski
2026-02-06 15:08 ` Greg Kroah-Hartman [this message]
2026-02-06 22:02 ` Paul E. McKenney
2026-02-09 11:13   ` Bartosz Golaszewski
2026-02-11  2:05     ` Tzung-Bi Shih
2026-02-11  4:59       ` Paul E. McKenney
2026-02-13  8:27         ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026020654-sadly-anchor-00bc@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rafael@kernel.org \
    --cc=shuah@kernel.org \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.