From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 783CAEE0AF1 for ; Sat, 7 Feb 2026 18:37:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D4FA110E12C; Sat, 7 Feb 2026 18:37:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="STazjiv5"; dkim-atps=neutral Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5980410E12C for ; Sat, 7 Feb 2026 18:37:29 +0000 (UTC) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47edd9024b1so19807905e9.3 for ; Sat, 07 Feb 2026 10:37:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770489448; x=1771094248; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1fc9JdHma9XDLTdFb3kvtPOeUV2ZhOtWSv7/jTyQxs8=; b=STazjiv50ohhrxH+BVYwGOHaiv20dITR4xC/eM65N70rqANNdzeXLn071rIXZpIQJD rsZ2X8gCs4L8TuIs4M5geX3GbZ2+Twj9ksbDvFUnyWTDq+nyzwELfa2afidMZfDZuq/1 L7eftKimChtBN9c+wJFkKOiTZFmCGdbI5QO1lyMfJxulHbrq5SWcxPNA31g0LXZ1sBmw gzplZoSNnoVYjW/Gbn65RVDGPi9dz3a+Y0s7UUe3e1urt64Hz+dF+jmKv6oQHdRva8z1 +j6wBbVjzbPQd68TapGbiTzCQPsWEzdBY8Yr5WomNVKaj5nXwl8lTdZESoP6Ws036Mve lyZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770489448; x=1771094248; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1fc9JdHma9XDLTdFb3kvtPOeUV2ZhOtWSv7/jTyQxs8=; b=C2FmJqxR1KSsQmLvfJjxcJ6FXFRKDp6LvO+qZJ3aP1Eda9eTfg5+HfKMTaVQu8d558 KCIEz69KXhxRggfXFj0Uu9Yf7OUKz/DmwPYyfbKMFPPiledqGvYX3v+5j0YJTi2b8W3c qC2d713Va62n4Hvlhho5WR36+Qml4XagG91acFSOWP5ka0w5jxSWNS57cpeIxvsWQYya ryea79aP6XWdEQ9xtt0g8xtmfDIv8klpZ+O3I+C55rZsvHmw524rO7jtz8uPj4ZFn8Vf 0BXGT7Au1vQoSqWtBW1y3taIM2EdNdikc08ZXeCHfV7hvAB5iW933Cd6rz11pkqwJLNa +kJw== X-Forwarded-Encrypted: i=1; AJvYcCWFrbMo7bXBgv6zEJU5+/12/lhFXdgCxGBwpGiqAZ/NxaeOlSjLoOgWV8V8YYiOw8rq/Gz2ezp/Js8=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwFpiAhg8eKR1M5rkKqjDUin72t3lUAnQlUN3xbW97Vei+hhysE hCc7PS5XmraS2QMQzDhIv0e/NzJC1eWNNZmRjqFU/kkN3UfDBE9WE/DB X-Gm-Gg: AZuq6aIRtxg/5K1v09ok0ljh1wFukQj/CFo054gNQjXvnEM644t1WkVDQNfCc6S4Wro OnMt5J4+mijozTFTiQymbvrz8hVxyVWAMdIzEkWYNJZn5h5OM5Q0ZWvEV3a/jkvZFGdVjfAzzVy VQ4pryUDrs5xFfJHdVIiePEqNK8VB+kZB/OHFQ8uHkNND4cfpbvhSfWOLGToqbUbmGLZt4gyfAb I01tiIRvjL+9zb/wX8E1M8fFrCwob4Vl3fnoUMm4U6G1+++w/YVVFnWlkmqUPolrUwtzyLxYj2F 9jK2CbL+pveoqTu7n3Hc3Z5Kgr/GpVGsWN5NE9IgVfGBBWIhUEE6JcoifjlfagYMbnH2c9T18l8 ju1rg6ROBzJtTjuH+bapsNpi5HVWcnztxp3mlNf5WYxzRgST59KAo5p2lcITGL0KM7nxTKEa/wL Ez7GkbdyliPy388QARvU+MtSO3AKy+mCSiHce6sZEZ5mVt X-Received: by 2002:a05:600c:34d1:b0:482:ef72:5787 with SMTP id 5b1f17b1804b1-483201da065mr81990065e9.1.1770489447388; Sat, 07 Feb 2026 10:37:27 -0800 (PST) Received: from osama.. ([197.46.155.47]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4832a38425asm72529845e9.7.2026.02.07.10.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 10:37:26 -0800 (PST) From: Osama Abdelkader To: Inki Dae , Jagan Teki , Marek Szyprowski , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH] drm/bridge: samsung-dsim: Fix memory leak in error path Date: Sat, 7 Feb 2026 19:37:20 +0100 Message-ID: <20260207183721.43087-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In samsung_dsim_host_attach(), drm_bridge_add() is called to add the bridge. However, if samsung_dsim_register_te_irq() or pdata->host_ops->attach() fails afterwards, the function returns without removing the bridge, causing a memory leak. Fix this by adding proper error handling with goto labels to ensure drm_bridge_remove() is called in all error paths. Also ensure that samsung_dsim_unregister_te_irq() is called if the attach operation fails after the TE IRQ has been registered. Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/bridge/samsung-dsim.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index eabc4c32f6ab..4712637749f8 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1881,6 +1881,8 @@ static int samsung_dsim_register_te_irq(struct samsung_dsim *dsi, struct device return 0; } +static void samsung_dsim_unregister_te_irq(struct samsung_dsim *dsi); + static int samsung_dsim_host_attach(struct mipi_dsi_host *host, struct mipi_dsi_device *device) { @@ -1955,13 +1957,13 @@ static int samsung_dsim_host_attach(struct mipi_dsi_host *host, if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO)) { ret = samsung_dsim_register_te_irq(dsi, &device->dev); if (ret) - return ret; + goto err_remove_bridge; } if (pdata->host_ops && pdata->host_ops->attach) { ret = pdata->host_ops->attach(dsi, device); if (ret) - return ret; + goto err_unregister_te_irq; } dsi->lanes = device->lanes; @@ -1969,6 +1971,13 @@ static int samsung_dsim_host_attach(struct mipi_dsi_host *host, dsi->mode_flags = device->mode_flags; return 0; + +err_unregister_te_irq: + if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO)) + samsung_dsim_unregister_te_irq(dsi); +err_remove_bridge: + drm_bridge_remove(&dsi->bridge); + return ret; } static void samsung_dsim_unregister_te_irq(struct samsung_dsim *dsi) -- 2.43.0