From: luka.gejak@linux.dev
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Luka Gejak <luka.gejak@linux.dev>
Subject: [PATCH v3 05/22] staging: rtl8723bs: convert PSTA_INFO_T to struct sta_info *
Date: Sun, 8 Feb 2026 12:00:54 +0100 [thread overview]
Message-ID: <20260208110111.46642-6-luka.gejak@linux.dev> (raw)
In-Reply-To: <20260208110111.46642-1-luka.gejak@linux.dev>
From: Luka Gejak <luka.gejak@linux.dev>
Replace the vendor-specific PSTA_INFO_T typedef with the standard Linux
kernel type 'struct sta_info *' throughout the driver.
This addresses the second TODO item: convert any remaining unusual
variable types.
Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
---
drivers/staging/rtl8723bs/hal/odm.c | 10 +++++-----
drivers/staging/rtl8723bs/hal/odm.h | 4 ++--
drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 2 +-
drivers/staging/rtl8723bs/hal/odm_types.h | 3 ---
4 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c
index 639b6da2302b..a22354f728c1 100644
--- a/drivers/staging/rtl8723bs/hal/odm.c
+++ b/drivers/staging/rtl8723bs/hal/odm.c
@@ -141,7 +141,7 @@ static void odm_CommonInfoSelfUpdate(struct dm_odm_t *pDM_Odm)
{
u8 EntryCnt = 0;
u8 i;
- PSTA_INFO_T pEntry;
+ struct sta_info *pEntry;
if (*(pDM_Odm->pBandWidth) == ODM_BW40M) {
if (*(pDM_Odm->pSecChOffset) == 1)
@@ -194,7 +194,7 @@ u32 ODM_Get_Rate_Bitmap(
u8 rssi_level
)
{
- PSTA_INFO_T pEntry;
+ struct sta_info *pEntry;
u32 rate_bitmap = 0;
u8 WirelessMode;
@@ -264,7 +264,7 @@ static void odm_RefreshRateAdaptiveMaskCE(struct dm_odm_t *pDM_Odm)
return;
for (i = 0; i < ODM_ASSOCIATE_ENTRY_NUM; i++) {
- PSTA_INFO_T pstat = pDM_Odm->pODM_StaInfo[i];
+ struct sta_info *pstat = pDM_Odm->pODM_StaInfo[i];
if (IS_STA_VALID(pstat)) {
if (is_multicast_ether_addr(pstat->hwaddr)) /* if (psta->mac_id == 1) */
@@ -841,7 +841,7 @@ void ODM_CmnInfoHook(struct dm_odm_t *pDM_Odm, enum odm_cmninfo_e CmnInfo, void
/* pDM_Odm->BTCoexist = (bool *)pValue; */
/* case ODM_CMNINFO_STA_STATUS: */
- /* pDM_Odm->pODM_StaInfo[] = (PSTA_INFO_T)pValue; */
+ /* pDM_Odm->pODM_StaInfo[] = (struct sta_info *)pValue; */
/* break; */
/* case ODM_CMNINFO_PHY_STATUS: */
@@ -875,7 +875,7 @@ void ODM_CmnInfoPtrArrayHook(
/* Dynamic call by reference pointer. */
/* */
case ODM_CMNINFO_STA_STATUS:
- pDM_Odm->pODM_StaInfo[Index] = (PSTA_INFO_T)pValue;
+ pDM_Odm->pODM_StaInfo[Index] = (struct sta_info *)pValue;
break;
/* To remove the compiler warning, must add an empty default statement to handle the other values. */
default:
diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 38830552d5bc..856d454b0181 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -853,7 +853,7 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
/* 2 Define STA info. */
/* _ODM_STA_INFO */
/* 2012/01/12 MH For MP, we need to reduce one array pointer for default port.?? */
- PSTA_INFO_T pODM_StaInfo[ODM_ASSOCIATE_ENTRY_NUM];
+ struct sta_info *pODM_StaInfo[ODM_ASSOCIATE_ENTRY_NUM];
/* */
/* 2012/02/14 MH Add to share 88E ra with other SW team. */
@@ -910,7 +910,7 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
/* u8 binitialized; for dm_initial_gain_Multi_STA use. */
/* for Antenna diversity */
/* u8 AntDivCfg; 0:OFF , 1:ON, 2:by efuse */
- /* PSTA_INFO_T RSSI_target; */
+ /* struct sta_info *RSSI_target; */
bool *pbDriverStopped;
bool *pbDriverIsGoingToPnpSetPowerSleep;
diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
index 994b8c578e7a..5bb27b872052 100644
--- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
+++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
@@ -256,7 +256,7 @@ static void odm_Process_RSSIForDM(
u8 RSSI_max, RSSI_min, i;
u32 OFDM_pkt = 0;
u32 Weighting = 0;
- PSTA_INFO_T pEntry;
+ struct sta_info *pEntry;
if (pPktinfo->station_id == 0xFF)
diff --git a/drivers/staging/rtl8723bs/hal/odm_types.h b/drivers/staging/rtl8723bs/hal/odm_types.h
index 8168dc14e879..893fa87852d8 100644
--- a/drivers/staging/rtl8723bs/hal/odm_types.h
+++ b/drivers/staging/rtl8723bs/hal/odm_types.h
@@ -33,9 +33,6 @@ enum hal_status {
#define ODM_ENDIAN_TYPE ODM_ENDIAN_BIG
#endif
- #define STA_INFO_T struct sta_info
- #define PSTA_INFO_T struct sta_info *
-
#define SET_TX_DESC_ANTSEL_A_88E(__pTxDesc, __Value) SET_BITS_TO_LE_4BYTE(__pTxDesc+8, 24, 1, __Value)
#define SET_TX_DESC_ANTSEL_B_88E(__pTxDesc, __Value) SET_BITS_TO_LE_4BYTE(__pTxDesc+8, 25, 1, __Value)
#define SET_TX_DESC_ANTSEL_C_88E(__pTxDesc, __Value) SET_BITS_TO_LE_4BYTE(__pTxDesc+28, 29, 1, __Value)
--
2.52.0
next prev parent reply other threads:[~2026-02-08 11:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 11:00 [PATCH v3 00/22] staging: rtl8723bs: fix out-of-bounds and various cleanups luka.gejak
2026-02-08 11:00 ` [PATCH v3 01/22] staging: rtl8723bs: fix potential out-of-bounds read in rtw_restruct_wmm_ie luka.gejak
2026-02-23 14:18 ` Greg Kroah-Hartman
2026-02-08 11:00 ` [PATCH v3 02/22] staging: rtl8723bs: remove unused rtl8192c function declarations luka.gejak
2026-02-08 11:00 ` [PATCH v3 03/22] staging: rtl8723bs: remove unused RECV_BLK defines luka.gejak
2026-02-08 11:00 ` [PATCH v3 04/22] staging: rtl8723bs: remove unused MAX_PATH_NUM defines luka.gejak
2026-02-08 11:00 ` luka.gejak [this message]
2026-02-08 11:00 ` [PATCH v3 06/22] staging: rtl8723bs: remove NDIS type aliases luka.gejak
2026-02-08 11:00 ` [PATCH v3 07/22] staging: rtl8723bs: remove redundant MAC_ARG macro luka.gejak
2026-02-08 11:00 ` [PATCH v3 08/22] staging: rtl8723bs: core: fix line lengths in rtw_wlan_util.c luka.gejak
2026-02-08 11:00 ` [PATCH v3 09/22] staging: rtl8723bs: core: fix line lengths in rtw_recv.c luka.gejak
2026-02-08 11:00 ` [PATCH v3 10/22] staging: rtl8723bs: hal: fix line lengths in HalPhyRf_8723B.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 11/22] staging: rtl8723bs: os_dep: fix line lengths in ioctl_cfg80211.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 12/22] staging: rtl8723bs: hal: fix line lengths in rtl8723b_cmd.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 13/22] staging: rtl8723bs: hal: fix line lengths in rtl8723b_hal_init.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 14/22] staging: rtl8723bs: hal: fix line lengths in rtl8723b_phycfg.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 15/22] staging: rtl8723bs: core: fix various line length overflows luka.gejak
2026-02-08 11:01 ` [PATCH v3 16/22] staging: rtl8723bs: hal: " luka.gejak
2026-02-08 11:01 ` [PATCH v3 17/22] staging: rtl8723bs: os_dep: " luka.gejak
2026-02-08 11:01 ` [PATCH v3 18/22] staging: rtl8723bs: core: fix line lengths in rtw_cmd.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 19/22] staging: rtl8723bs: core: fix line lengths in rtw_mlme_ext.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 20/22] staging: rtl8723bs: core: fix line lengths in rtw_mlme.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 21/22] staging: rtl8723bs: core: fix line lengths in rtw_xmit.c luka.gejak
2026-02-08 11:01 ` [PATCH v3 22/22] staging: rtl8723bs: core: fix various line length overflows luka.gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260208110111.46642-6-luka.gejak@linux.dev \
--to=luka.gejak@linux.dev \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.