From: Rob Herring <robh@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: webgeek1234@gmail.com, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kumar Sharma <quic_vksharma@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Lei Chen <quic_chenlei@quicinc.com>
Subject: Re: [PATCH 2/3] arm64: dts: qcom: sm8550: Add tz-log node
Date: Mon, 9 Feb 2026 11:07:14 -0600 [thread overview]
Message-ID: <20260209170714.GB1401643-robh@kernel.org> (raw)
In-Reply-To: <eef70e37-3841-47f3-a436-13e18c157176@oss.qualcomm.com>
On Fri, Jan 30, 2026 at 11:59:15AM +0100, Konrad Dybcio wrote:
> On 1/29/26 8:46 AM, Aaron Kling via B4 Relay wrote:
> > From: Lei Chen <quic_chenlei@quicinc.com>
> >
> > Add DT node to enable tz-log driver.
> >
> > Signed-off-by: Lei Chen <quic_chenlei@quicinc.com>
> > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > ---
>
> It's nice that you preserved the original authorship.
>
> Please extend the rather lackluster commit message to explain the
> "why", which is notably different from the original downstream
> addition, since your goal here is to mainly appease a grumpy
> bootloader.
Humm, that's certainly good to know. Though I don't think it will help
the case for this binding.
Rob
next prev parent reply other threads:[~2026-02-09 17:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 7:46 [PATCH 0/3] arm64: dts: qcom: sm8550: Fix DTBO boot failure Aaron Kling
2026-01-29 7:46 ` Aaron Kling via B4 Relay
2026-01-29 7:46 ` [PATCH 1/3] dt-bindings: firmware: Add tz-log doc Aaron Kling
2026-01-29 7:46 ` Aaron Kling via B4 Relay
2026-02-09 17:03 ` Rob Herring
2026-01-29 7:46 ` [PATCH 2/3] arm64: dts: qcom: sm8550: Add tz-log node Aaron Kling
2026-01-29 7:46 ` Aaron Kling via B4 Relay
2026-01-30 10:59 ` Konrad Dybcio
2026-02-03 4:25 ` Aaron Kling
2026-02-03 9:28 ` Konrad Dybcio
2026-02-04 3:15 ` Aaron Kling
2026-02-09 17:11 ` Rob Herring
2026-02-09 17:07 ` Rob Herring [this message]
2026-02-10 8:50 ` Konrad Dybcio
2026-01-29 7:46 ` [PATCH 3/3] arm64: dts: qcom: sm8550: Fix DTBO boot failure Aaron Kling
2026-01-29 7:46 ` Aaron Kling via B4 Relay
2026-01-31 7:47 ` Dmitry Baryshkov
2026-01-31 9:09 ` Aaron Kling
2026-01-31 10:33 ` Dmitry Baryshkov
2026-02-03 4:42 ` Aaron Kling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260209170714.GB1401643-robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_chenlei@quicinc.com \
--cc=quic_vksharma@quicinc.com \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.