From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Fabiano Rosas" <farosas@suse.de>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: "Jamin Lin" <jamin_lin@aspeedtech.com>,
"Troy Lee" <troy_lee@aspeedtech.com>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"nabihestefan@google.com" <nabihestefan@google.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH v2 01/11] hw/misc/aspeed_scu: Remove unused SoC silicon revision definitions
Date: Tue, 10 Feb 2026 05:10:10 +0000 [thread overview]
Message-ID: <20260210051008.355149-2-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260210051008.355149-1-jamin_lin@aspeedtech.com>
Several legacy Aspeed SoC silicon revision definitions are no longer
used by any machine models or runtime logic.
Remove unused silicon revision macros and corresponding entries from
the silicon revision table to reduce dead code and improve
maintainability.
No functional change intended.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
---
include/hw/misc/aspeed_scu.h | 10 ----------
hw/misc/aspeed_scu.c | 10 ----------
2 files changed, 20 deletions(-)
diff --git a/include/hw/misc/aspeed_scu.h b/include/hw/misc/aspeed_scu.h
index 9e28bd4d2e..313a79f2f7 100644
--- a/include/hw/misc/aspeed_scu.h
+++ b/include/hw/misc/aspeed_scu.h
@@ -41,22 +41,12 @@ struct AspeedSCUState {
uint32_t hw_prot_key;
};
-#define AST2400_A0_SILICON_REV 0x02000303U
#define AST2400_A1_SILICON_REV 0x02010303U
-#define AST2500_A0_SILICON_REV 0x04000303U
#define AST2500_A1_SILICON_REV 0x04010303U
-#define AST2600_A0_SILICON_REV 0x05000303U
-#define AST2600_A1_SILICON_REV 0x05010303U
-#define AST2600_A2_SILICON_REV 0x05020303U
#define AST2600_A3_SILICON_REV 0x05030303U
-#define AST1030_A0_SILICON_REV 0x80000000U
#define AST1030_A1_SILICON_REV 0x80010000U
#define AST1060_A2_SILICON_REV 0xA0030000U
-#define AST2700_A0_SILICON_REV 0x06000103U
-#define AST2720_A0_SILICON_REV 0x06000203U
-#define AST2750_A0_SILICON_REV 0x06000003U
#define AST2700_A1_SILICON_REV 0x06010103U
-#define AST2750_A1_SILICON_REV 0x06010003U
#define ASPEED_IS_AST2500(si_rev) ((((si_rev) >> 24) & 0xff) == 0x04)
diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
index 6829efa2dc..0edf9c1b16 100644
--- a/hw/misc/aspeed_scu.c
+++ b/hw/misc/aspeed_scu.c
@@ -555,22 +555,12 @@ static void aspeed_scu_reset(DeviceState *dev)
}
static uint32_t aspeed_silicon_revs[] = {
- AST2400_A0_SILICON_REV,
AST2400_A1_SILICON_REV,
- AST2500_A0_SILICON_REV,
AST2500_A1_SILICON_REV,
- AST2600_A0_SILICON_REV,
- AST2600_A1_SILICON_REV,
- AST2600_A2_SILICON_REV,
AST2600_A3_SILICON_REV,
- AST1030_A0_SILICON_REV,
AST1030_A1_SILICON_REV,
AST1060_A2_SILICON_REV,
- AST2700_A0_SILICON_REV,
- AST2720_A0_SILICON_REV,
- AST2750_A0_SILICON_REV,
AST2700_A1_SILICON_REV,
- AST2750_A1_SILICON_REV,
};
bool is_supported_silicon_rev(uint32_t silicon_rev)
--
2.43.0
next prev parent reply other threads:[~2026-02-10 5:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 5:10 [PATCH v2 00/11] Support ASPEED AST2700 A2 Jamin Lin
2026-02-10 5:10 ` Jamin Lin [this message]
2026-02-10 5:10 ` [PATCH v2 02/11] hw/misc/aspeed_scu: Add AST2700 A2 silicon revisions Jamin Lin
2026-02-10 5:10 ` [PATCH v2 03/11] hw/arm/aspeed_ast27x0: Add AST2700 A2 SoC support Jamin Lin
2026-02-10 7:14 ` Cédric Le Goater
2026-02-10 19:25 ` Nabih Estefan
2026-02-10 5:10 ` [PATCH v2 04/11] hw/arm/aspeed_ast27x0_evb: Add AST2700 A2 EVB machine Jamin Lin
2026-02-10 7:15 ` Cédric Le Goater
2026-02-10 5:10 ` [PATCH v2 05/11] hw/arm/aspeed_ast27x0_evb: Move ast2700-evb alias to AST2700 A2 EVB Jamin Lin
2026-02-10 15:11 ` Cédric Le Goater
2026-02-10 5:10 ` [PATCH v2 06/11] tests/qtest/ast2700-hace-test: Use ast2700-evb alias for AST2700 HACE tests Jamin Lin
2026-02-10 5:10 ` [PATCH v2 07/11] tests/functional/aarch64/test_aspeed_ast2700: Rename AST2700 A1 test to reduce test runtime Jamin Lin
2026-02-10 7:15 ` Cédric Le Goater
2026-02-10 5:10 ` [PATCH v2 08/11] tests/functional/aarch64/test_aspeed_ast2700: Add AST2700 A2 EVB functional tests Jamin Lin
2026-02-10 15:15 ` Cédric Le Goater
2026-02-11 1:59 ` Jamin Lin
2026-02-10 5:10 ` [PATCH v2 09/11] hw/arm/aspeed_ast27x0-fc: Switch AST2700 FC machine to A2 SoC Jamin Lin
2026-02-10 7:16 ` Cédric Le Goater
2026-02-10 5:10 ` [PATCH v2 10/11] hw/arm/aspeed_ast27x0-fc: Increase BMC DRAM size to 2GB for AST2700 A2 Jamin Lin
2026-02-10 7:16 ` Cédric Le Goater
2026-02-10 5:10 ` [PATCH v2 11/11] tests/functional/aarch64/test_aspeed_ast2700fc: Use AST2700 A2 SDK image for FC tests Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210051008.355149-2-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=clg@redhat.com \
--cc=farosas@suse.de \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=lvivier@redhat.com \
--cc=nabihestefan@google.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.