From: kernel test robot <lkp@intel.com>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [koverstreet-bcachefs:bcachefs-rebalance_v2 468/799] fs/bcachefs/fs/dirent.c:157:5-8: Unneeded variable: "ret". Return "0" on line 207
Date: Tue, 10 Feb 2026 12:30:49 +0800 [thread overview]
Message-ID: <202602101217.RYZf9R3D-lkp@intel.com> (raw)
tree: https://github.com/koverstreet/bcachefs bcachefs-rebalance_v2
head: d4b3d00447faf8d4d95db47e3902e4ca4db8fbdc
commit: 0e349fe46a443dc2f5f3d2b67a3cc42c12d2bf35 [468/799] bcachefs: move fs code to fs/
config: arc-randconfig-r063-20260210 (https://download.01.org/0day-ci/archive/20260210/202602101217.RYZf9R3D-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 14.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602101217.RYZf9R3D-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> fs/bcachefs/fs/dirent.c:157:5-8: Unneeded variable: "ret". Return "0" on line 207
--
>> fs/bcachefs/fs/inode.c:505:5-8: Unneeded variable: "ret". Return "0" on line 538
fs/bcachefs/fs/inode.c:852:5-8: Unneeded variable: "ret". Return "0" on line 858
fs/bcachefs/fs/inode.c:872:5-8: Unneeded variable: "ret". Return "0" on line 878
--
>> fs/bcachefs/fs/quota.c:65:5-8: Unneeded variable: "ret". Return "0" on line 72
--
>> fs/bcachefs/fs/xattr.c:80:5-8: Unneeded variable: "ret". Return "0" on line 104
vim +157 fs/bcachefs/fs/dirent.c
1c6fdbd8f2465d fs/bcachefs/dirent.c Kent Overstreet 2017-03-16 149
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 150 int bch2_dirent_validate(struct bch_fs *c, struct bkey_s_c k,
a6f4794fcd8627 fs/bcachefs/dirent.c Kent Overstreet 2024-11-27 151 struct bkey_validate_context from)
1c6fdbd8f2465d fs/bcachefs/dirent.c Kent Overstreet 2017-03-16 152 {
26609b619fa230 fs/bcachefs/dirent.c Kent Overstreet 2018-11-01 153 struct bkey_s_c_dirent d = bkey_s_c_to_dirent(k);
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 154 unsigned name_block_len = bch2_dirent_name_bytes(d);
01a7e74fe14179 fs/bcachefs/dirent.c Joshua Ashton 2023-08-12 155 struct qstr d_name = bch2_dirent_get_name(d);
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 156 struct qstr d_cf_name = bch2_dirent_get_casefold_name(d);
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 @157 int ret = 0;
1c6fdbd8f2465d fs/bcachefs/dirent.c Kent Overstreet 2017-03-16 158
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 159 bkey_fsck_err_on(!d_name.len,
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 160 c, dirent_empty_name,
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 161 "empty name");
1c6fdbd8f2465d fs/bcachefs/dirent.c Kent Overstreet 2017-03-16 162
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 163 bkey_fsck_err_on(d_name.len + d_cf_name.len > name_block_len,
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 164 c, dirent_val_too_big,
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 165 "dirent names exceed bkey size (%d + %d > %d)",
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 166 d_name.len, d_cf_name.len, name_block_len);
1c6fdbd8f2465d fs/bcachefs/dirent.c Kent Overstreet 2017-03-16 167
a125c0742ccb0b fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 168 /*
a125c0742ccb0b fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 169 * Check new keys don't exceed the max length
a125c0742ccb0b fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 170 * (older keys may be larger.)
a125c0742ccb0b fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 171 */
a6f4794fcd8627 fs/bcachefs/dirent.c Kent Overstreet 2024-11-27 172 bkey_fsck_err_on((from.flags & BCH_VALIDATE_commit) && d_name.len > BCH_NAME_MAX,
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 173 c, dirent_name_too_long,
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 174 "dirent name too big (%u > %u)",
01a7e74fe14179 fs/bcachefs/dirent.c Joshua Ashton 2023-08-12 175 d_name.len, BCH_NAME_MAX);
b6d4f474e4e785 fs/bcachefs/dirent.c Kent Overstreet 2021-04-06 176
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 177 bkey_fsck_err_on(d_name.len != strnlen(d_name.name, d_name.len),
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 178 c, dirent_name_embedded_nul,
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 179 "dirent has stray data after name's NUL");
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 180
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 181 bkey_fsck_err_on((d_name.len == 1 && !memcmp(d_name.name, ".", 1)) ||
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 182 (d_name.len == 2 && !memcmp(d_name.name, "..", 2)),
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 183 c, dirent_name_dot_or_dotdot,
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 184 "invalid name");
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 185
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 186 bkey_fsck_err_on(memchr(d_name.name, '/', d_name.len),
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 187 c, dirent_name_has_slash,
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 188 "name with /");
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 189
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 190 bkey_fsck_err_on(d.v->d_type != DT_SUBVOL &&
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 191 le64_to_cpu(d.v->d_inum) == d.k->p.inode,
d97de0d017cde0 fs/bcachefs/dirent.c Kent Overstreet 2024-08-12 192 c, dirent_to_itself,
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 193 "dirent points to own directory");
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 194
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 195 if (d.v->d_casefold) {
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 196 bkey_fsck_err_on(from.from == BKEY_VALIDATE_commit &&
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 197 d_cf_name.len > BCH_NAME_MAX,
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 198 c, dirent_cf_name_too_big,
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 199 "dirent w/ cf name too big (%u > %u)",
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 200 d_cf_name.len, BCH_NAME_MAX);
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 201
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 202 bkey_fsck_err_on(d_cf_name.len != strnlen(d_cf_name.name, d_cf_name.len),
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 203 c, dirent_stray_data_after_cf_name,
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 204 "dirent has stray data after cf name's NUL");
d37c14ac6f05ec fs/bcachefs/dirent.c Joshua Ashton 2023-08-13 205 }
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 206 fsck_err:
b65db750e2bb92 fs/bcachefs/dirent.c Kent Overstreet 2023-10-24 @207 return ret;
1c6fdbd8f2465d fs/bcachefs/dirent.c Kent Overstreet 2017-03-16 208 }
1c6fdbd8f2465d fs/bcachefs/dirent.c Kent Overstreet 2017-03-16 209
:::::: The code at line 157 was first introduced by commit
:::::: b65db750e2bb9252321fd54c284edd73c1595a09 bcachefs: Enumerate fsck errors
:::::: TO: Kent Overstreet <kent.overstreet@linux.dev>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-02-10 4:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202602101217.RYZf9R3D-lkp@intel.com \
--to=lkp@intel.com \
--cc=kent.overstreet@linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.