From: Lukas Straub <lukasstraub2@web.de>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Zhang Chen <zhangckid@gmail.com>,
Hailiang Zhang <zhanghailiang@xfusion.com>,
Markus Armbruster <armbru@redhat.com>,
Li Zhijian <lizhijian@fujitsu.com>,
"Dr. David Alan Gilbert" <dave@treblig.org>
Subject: Re: [PATCH v5 05/16] colo: Remove ENABLE_COLO loadvm command functions
Date: Tue, 10 Feb 2026 14:28:35 +0100 [thread overview]
Message-ID: <20260210142835.6622e72e@penguin> (raw)
In-Reply-To: <aYoHn5DSsia4mxMW@x1.local>
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
On Mon, 9 Feb 2026 11:13:19 -0500
Peter Xu <peterx@redhat.com> wrote:
> On Tue, Feb 03, 2026 at 11:15:11AM +0100, Lukas Straub wrote:
> > No need for it anymore now that x-colo capability is required
> > on incoming side.
> >
> > Reviewed-by: Fabiano Rosas <farosas@suse.de>
> > Signed-off-by: Lukas Straub <lukasstraub2@web.de>
>
> IIUC this patch needs to be squashed into the next or it will break COLO..
>
No it's fine actually. Now when we receive the MIG_CMD_ENABLE_COLO
command, we just go to the return 0 at the end of
loadvm_process_command().
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-02-10 13:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 10:15 [PATCH v5 00/16] migration: Add COLO multifd support and COLO migration unit test Lukas Straub
2026-02-03 10:15 ` [PATCH v5 01/16] MAINTAINERS: Add myself as maintainer for COLO migration framework Lukas Straub
2026-02-03 10:15 ` [PATCH v5 02/16] MAINTAINERS: Remove Hailiang Zhang from " Lukas Straub
2026-02-03 10:15 ` [PATCH v5 03/16] colo: Setup ram cache in normal migration path Lukas Straub
2026-02-09 16:10 ` Peter Xu
2026-02-03 10:15 ` [PATCH v5 04/16] colo: Replace migration_incoming_colo_enabled() with migrate_colo() Lukas Straub
2026-02-09 16:11 ` Peter Xu
2026-02-03 10:15 ` [PATCH v5 05/16] colo: Remove ENABLE_COLO loadvm command functions Lukas Straub
2026-02-09 16:13 ` Peter Xu
2026-02-10 13:28 ` Lukas Straub [this message]
2026-02-10 14:38 ` Peter Xu
2026-02-10 15:34 ` Lukas Straub
2026-02-03 10:15 ` [PATCH v5 06/16] colo: Don't send ENABLE_COLO command Lukas Straub
2026-02-09 16:17 ` Peter Xu
2026-02-10 13:29 ` Lukas Straub
2026-02-03 10:15 ` [PATCH v5 07/16] ram: Remove colo special-casing Lukas Straub
2026-02-09 16:19 ` Peter Xu
2026-02-03 10:15 ` [PATCH v5 08/16] Move ram state receive into multifd_ram_state_recv() Lukas Straub
2026-02-09 16:20 ` Peter Xu
2026-02-03 10:15 ` [PATCH v5 09/16] multifd: Add COLO support Lukas Straub
2026-02-04 18:13 ` Fabiano Rosas
2026-02-09 16:25 ` Peter Xu
2026-02-03 10:15 ` [PATCH v5 10/16] Call colo_release_ram_cache() after multifd threads terminate Lukas Straub
2026-02-09 16:27 ` Peter Xu
2026-02-03 10:15 ` [PATCH v5 11/16] colo: Fix crash during device vmstate load Lukas Straub
2026-02-03 10:15 ` [PATCH v5 12/16] migration-test: Add COLO migration unit test Lukas Straub
2026-02-09 15:56 ` Peter Xu
2026-02-03 10:15 ` [PATCH v5 13/16] Convert colo main documentation to restructuredText Lukas Straub
2026-02-06 7:47 ` Zhang Chen
2026-02-03 10:15 ` [PATCH v5 14/16] qemu-colo.rst: Miscellaneous changes Lukas Straub
2026-02-06 7:52 ` Zhang Chen
2026-02-03 10:15 ` [PATCH v5 15/16] qemu-colo.rst: Add my copyright Lukas Straub
2026-02-03 10:15 ` [PATCH v5 16/16] qemu-colo.rst: Simplify the block replication setup Lukas Straub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210142835.6622e72e@penguin \
--to=lukasstraub2@web.de \
--cc=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=farosas@suse.de \
--cc=lizhijian@fujitsu.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.