From: Christoph Hellwig <hch@lst.de>
To: Wilfred Mallawa <wilfred.opensource@gmail.com>
Cc: Carlos Maiolino <cem@kernel.org>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Wilfred Mallawa <wilfred.mallawa@wdc.com>
Subject: Re: [PATCH v2 2/2] xfs: add static size checks for ioctl UABI
Date: Tue, 10 Feb 2026 16:35:59 +0100 [thread overview]
Message-ID: <20260210153559.GB31245@lst.de> (raw)
In-Reply-To: <20260210055942.2844783-5-wilfred.opensource@gmail.com>
On Tue, Feb 10, 2026 at 03:59:44PM +1000, Wilfred Mallawa wrote:
> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
>
> The ioctl structures in libxfs/xfs_fs.h are missing static size checks.
> It is useful to have static size checks for these structures as adding
> new fields to them could cause issues (e.g. extra padding that may be
> inserted by the compiler). So add these checks to xfs/xfs_ondisk.h.
>
> Due to different padding/alignment requirements across different
> architectures, to avoid build failures, some structures are ommited from
> the size checks. For example, structures with "compat_" definitions in
> xfs/xfs_ioctl32.h are ommited.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
I couldn't spot any whitespace issues either, although I'd personally
drop the last empty line if I had to nitpick.
next prev parent reply other threads:[~2026-02-10 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 5:59 [PATCH v2 1/2] xfs: remove duplicate static size checks Wilfred Mallawa
2026-02-10 5:59 ` [PATCH v2 2/2] xfs: add static size checks for ioctl UABI Wilfred Mallawa
2026-02-10 6:05 ` Wilfred Mallawa
2026-02-10 15:35 ` Christoph Hellwig [this message]
2026-02-11 3:31 ` Wilfred Mallawa
2026-02-10 15:34 ` [PATCH v2 1/2] xfs: remove duplicate static size checks Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210153559.GB31245@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=wilfred.mallawa@wdc.com \
--cc=wilfred.opensource@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.