From: Kees Cook <kees@kernel.org>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
"Theodore Ts'o" <tytso@mit.edu>, 李龙兴 <coregee2000@gmail.com>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, "Jan Kara" <jack@suse.cz>
Subject: Re: [PATCH] ext4: Reject on-disk mount options with missing NUL-terminator
Date: Tue, 10 Feb 2026 17:50:00 -0800 [thread overview]
Message-ID: <202602101749.40E8AB05@keescook> (raw)
In-Reply-To: <20260210115731-8a60c77ca684b6684fb8955f-pchelkin@ispras>
On Tue, Feb 10, 2026 at 12:03:35PM +0300, Fedor Pchelkin wrote:
> If I understand the issue correctly, it's already being rejected with the
> existing check:
>
> if (strscpy_pad(s_mount_opts, sbi->s_es->s_mount_opts) < 0)
> return -E2BIG;
>
> If the source string is truncated at least by one symbol (which is the
> case for unterminated string), strscpy_pad() returns -E2BIG and the mount
> fails.
Agreed. Sorry for the noise! Things appear to be fine as-is. I had
missed the version tested in the original report.
--
Kees Cook
prev parent reply other threads:[~2026-02-11 1:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 21:27 [PATCH] ext4: Reject on-disk mount options with missing NUL-terminator Kees Cook
2026-02-06 21:45 ` Darrick J. Wong
2026-02-06 21:56 ` Kees Cook
2026-02-08 13:43 ` Andy Shevchenko
2026-02-09 17:27 ` Fedor Pchelkin
2026-02-09 20:00 ` Kees Cook
2026-02-10 5:01 ` Darrick J. Wong
2026-02-10 9:03 ` Fedor Pchelkin
2026-02-11 1:50 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202602101749.40E8AB05@keescook \
--to=kees@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=andriy.shevchenko@intel.com \
--cc=coregee2000@gmail.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pchelkin@ispras.ru \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.