All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Aleksei Oladko <aleksey.oladko@virtuozzo.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Petr Machata <petrm@nvidia.com>, Amit Cohen <amcohen@nvidia.com>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] selftests: forwarding: vxlan_bridge_1d: fix test failure with br_netfilter enabled
Date: Wed, 11 Feb 2026 10:29:50 +0200	[thread overview]
Message-ID: <20260211082950.GA481121@shredder> (raw)
In-Reply-To: <20260210185129.480015-2-aleksey.oladko@virtuozzo.com>

On Tue, Feb 10, 2026 at 06:51:27PM +0000, Aleksei Oladko wrote:
> The test generates VXLAN traffic using mausezahn, where the encapsulated
> inner IPv4 packet contains a zero IP header checksum. After VXLAN
> decapsulation, such packets do not pass sanity checks in br_netfilter
> and are dropped, which causes the test to fail.
> 
> Fix this by calculating and setting a valid IPv4 header checksum for the
> encapsulated packet generated by mausezahn, so that the packet is accepted
> by br_netfilter.
> 
> Signed-off-by: Aleksei Oladko <aleksey.oladko@virtuozzo.com>

If you are targeting this as a fix, then:

1. Use "[PATCH net]" as subject prefix. See [1].

2. Add a Fixes tag.

3. Please mention in the commit message that this is fixed by using the
payload_template_calc_checksum() / payload_template_expand_checksum()
helpers that are only available in v6.3 and newer kernels.

Patch looks good otherwise (I also tested it).

[1] https://docs.kernel.org/process/maintainer-netdev.html

  reply	other threads:[~2026-02-11  8:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 18:51 [PATCH 0/3] selftests: forwarding: fix br_netfilter related test failures Aleksei Oladko
2026-02-10 18:51 ` [PATCH 1/3] selftests: forwarding: vxlan_bridge_1d: fix test failure with br_netfilter enabled Aleksei Oladko
2026-02-11  8:29   ` Ido Schimmel [this message]
2026-02-10 18:51 ` [PATCH 2/3] selftests: forwarding: vxlan_bridge_1d_ipv6: " Aleksei Oladko
2026-02-10 18:51 ` [PATCH 3/3] selftests: forwarding: fix pedit tests " Aleksei Oladko
2026-02-10 23:34   ` Jakub Kicinski
2026-02-11  8:11   ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260211082950.GA481121@shredder \
    --to=idosch@nvidia.com \
    --cc=aleksey.oladko@virtuozzo.com \
    --cc=amcohen@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.