From: Jakub Kicinski <kuba@kernel.org>
To: Cosmin Ratiu <cratiu@nvidia.com>
Cc: Tariq Toukan <tariqt@nvidia.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"donald.hunter@gmail.com" <donald.hunter@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"leon@kernel.org" <leon@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Jiri Pirko <jiri@nvidia.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Carolina Jubran <cjubran@nvidia.com>,
"horms@kernel.org" <horms@kernel.org>,
Mark Bloch <mbloch@nvidia.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
Saeed Mahameed <saeedm@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Gal Pressman <gal@nvidia.com>, Moshe Shemesh <moshe@nvidia.com>,
"krzk@kernel.org" <krzk@kernel.org>
Subject: Re: [PATCH net-next V7 07/14] devlink: Add parent dev to devlink API
Date: Wed, 11 Feb 2026 08:57:38 -0800 [thread overview]
Message-ID: <20260211085738.5835f812@kernel.org> (raw)
In-Reply-To: <9d3d4e49cec85473619eb5166f01168a6ae3fd85.camel@nvidia.com>
On Wed, 11 Feb 2026 16:28:14 +0000 Cosmin Ratiu wrote:
> > > + /* Drop the parent devlink lock but don't release
> > > the reference.
> > > + * This will keep it alive until the end of the
> > > request.
> > > + */
> >
> > To be clear -- devlink instances do not behave like netdev instances.
> > netdev instances prevent unregistration of the netdev.
> > devlink refs are normal refs, they just keep the memory around.
> > If memory serves me..
>
> If no reference is held, a concurrent user op could release the parent
> devlink instance altogether, and free its memory, that's the reason for
> keeping a ref alive for the duration of this request.
I suppose my comment was more about using the word "alive"
in networking context. I associate "alive" with registered.
See dev_isalive(). Here you're just keeping the object
from being freed.
next prev parent reply other threads:[~2026-02-11 16:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 11:25 [PATCH net-next V7 00/14] devlink and mlx5: Support cross-function rate scheduling Tariq Toukan
2026-01-28 11:25 ` [PATCH net-next V7 01/14] documentation: networking: add shared devlink documentation Tariq Toukan
2026-02-03 3:40 ` Jakub Kicinski
2026-02-03 9:18 ` Jiri Pirko
2026-02-04 3:01 ` Jakub Kicinski
2026-02-04 7:12 ` Jiri Pirko
2026-02-05 2:02 ` Jakub Kicinski
2026-02-06 10:52 ` Jiri Pirko
2026-02-07 1:50 ` Jakub Kicinski
2026-01-28 11:25 ` [PATCH net-next V7 02/14] devlink: introduce shared devlink instance for PFs on same chip Tariq Toukan
2026-02-03 3:49 ` Jakub Kicinski
2026-02-03 9:44 ` Jiri Pirko
2026-02-04 2:42 ` Jakub Kicinski
2026-02-04 7:15 ` Jiri Pirko
2026-02-05 2:06 ` Jakub Kicinski
2026-01-28 11:25 ` [PATCH net-next V7 03/14] devlink: Reverse locking order for nested instances Tariq Toukan
2026-01-28 11:25 ` [PATCH net-next V7 04/14] devlink: Add helpers to lock nested-in instances Tariq Toukan
2026-01-28 11:25 ` [PATCH net-next V7 05/14] devlink: Refactor devlink_rate_nodes_check Tariq Toukan
2026-01-28 11:25 ` [PATCH net-next V7 06/14] devlink: Decouple rate storage from associated devlink object Tariq Toukan
2026-01-28 11:25 ` [PATCH net-next V7 07/14] devlink: Add parent dev to devlink API Tariq Toukan
2026-02-03 4:00 ` Jakub Kicinski
2026-02-11 16:28 ` Cosmin Ratiu
2026-02-11 16:57 ` Jakub Kicinski [this message]
2026-01-28 11:25 ` [PATCH net-next V7 08/14] devlink: Allow parent dev for rate-set and rate-new Tariq Toukan
2026-01-28 11:25 ` [PATCH net-next V7 09/14] devlink: Allow rate node parents from other devlinks Tariq Toukan
2026-02-03 4:04 ` Jakub Kicinski
2026-01-28 11:25 ` [PATCH net-next V7 10/14] net/mlx5: Add a shared devlink instance for PFs on same chip Tariq Toukan
2026-01-28 11:25 ` [PATCH net-next V7 11/14] net/mlx5: Expose a function to clear a vport's parent Tariq Toukan
2026-01-28 11:25 ` [PATCH net-next V7 12/14] net/mlx5: Store QoS sched nodes in the sh_devlink Tariq Toukan
2026-01-28 11:25 ` [PATCH net-next V7 13/14] net/mlx5: qos: Support cross-device tx scheduling Tariq Toukan
2026-01-28 11:25 ` [PATCH net-next V7 14/14] net/mlx5: Document devlink rates Tariq Toukan
2026-02-03 4:09 ` [PATCH net-next V7 00/14] devlink and mlx5: Support cross-function rate scheduling Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211085738.5835f812@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=krzk@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.