All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/4] tracing: Reset last_boot_info if ring buffer is reset
Date: Wed, 11 Feb 2026 13:28:48 -0500	[thread overview]
Message-ID: <20260211132848.2bda172a@fedora> (raw)
In-Reply-To: <20260206225051.f22b670b54e8906a4bc1bec9@kernel.org>

On Fri, 6 Feb 2026 22:50:51 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> On Wed, 4 Feb 2026 20:40:49 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Sun,  1 Feb 2026 12:29:07 +0900
> > "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> >   
> > > @@ -8036,6 +8042,7 @@ tracing_snapshot_write(struct file *filp, const char __user *ubuf, size_t cnt,
> > >  				tracing_reset_online_cpus(&tr->max_buffer);
> > >  			else
> > >  				tracing_reset_cpu(&tr->max_buffer, iter->cpu_file);
> > > +			update_last_data_if_empty(tr);  
> > 
> > Is this needed? Memory mapped buffers (which the persistent ring buffer
> > is) do not have snapshot buffers.  
> 
> Yeah, I did this just for consistency. But it is better to just leave
> the comment here.
> 

I have code to move all the snapshot buffers into its own file. I'm
going to drop this one as I think leaving it makes it more confusing.

-- Steve

  reply	other threads:[~2026-02-11 18:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-01  3:28 [PATCH v6 0/4] tracing: Remove backup instance after read all Masami Hiramatsu (Google)
2026-02-01  3:29 ` [PATCH v6 1/4] tracing: Reset last_boot_info if ring buffer is reset Masami Hiramatsu (Google)
2026-02-05  1:40   ` Steven Rostedt
2026-02-06 13:50     ` Masami Hiramatsu
2026-02-11 18:28       ` Steven Rostedt [this message]
2026-02-11 18:33         ` Steven Rostedt
2026-02-01  3:29 ` [PATCH v6 2/4] tracing: Make the backup instance non-reusable Masami Hiramatsu (Google)
2026-02-05  2:17   ` Steven Rostedt
2026-02-09  9:08     ` Masami Hiramatsu
2026-02-09 23:42       ` Steven Rostedt
2026-02-10  5:14         ` Masami Hiramatsu
2026-02-11 15:42           ` Steven Rostedt
2026-02-12  4:24             ` Masami Hiramatsu
2026-02-01  3:29 ` [PATCH v6 3/4] tracing: Remove the backup instance automatically after read Masami Hiramatsu (Google)
2026-02-01  3:29 ` [PATCH v6 4/4] tracing/Documentation: Add a section about backup instance Masami Hiramatsu (Google)
2026-02-05  0:41 ` [PATCH v6 0/4] tracing: Remove backup instance after read all Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260211132848.2bda172a@fedora \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.