Re: [PULL 0/1] Tracing patches

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

On Wed, Feb 11, 2026 at 03:21:07PM +0000, Daniel P. Berrangé wrote:
> On Wed, Feb 11, 2026 at 03:12:18PM +0000, Peter Maydell wrote:
> > On Tue, 10 Feb 2026 at 20:14, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > >
> > > The following changes since commit 0b91040d23dc8820724a60c811223b777f3bc6b7:
> > >
> > >   Merge tag 'pull-loongarch-20260210' of https://github.com/gaosong715/qemu into staging (2026-02-10 09:12:38 +0000)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request
> > >
> > > for you to fetch changes up to 80c15bcc5eb6d30abf90b2fd120cdf01f6ed2082:
> > >
> > >   tracetool-test: add QEMU_TEST_KEEP_SCRATCH=1 support (2026-02-10 14:47:14 -0500)
> > >
> > > ----------------------------------------------------------------
> > > Pull request
> > >
> > > ----------------------------------------------------------------
> > >
> > > Stefan Hajnoczi (1):
> > >   tracetool-test: add QEMU_TEST_KEEP_SCRATCH=1 support
> > >
> > >  tests/tracetool/tracetool-test.py | 24 ++++++++++++++++++++----
> > >  1 file changed, 20 insertions(+), 4 deletions(-)
> > 
> > This change seems to use some Python construct not supported
> > by all our platforms. CI job failures due to the tracetool tests
> > failing:
> > 
> > https://gitlab.com/qemu-project/qemu/-/jobs/13074647460
> > https://gitlab.com/qemu-project/qemu/-/jobs/13074647473
> > 
> > Traceback (most recent call last):
> >   File "/builds/qemu-project/qemu/tests/tracetool/tracetool-test.py",
> > line 121, in <module>
> >     with tempfile.TemporaryDirectory(prefix=sys.argv[4],
> > TypeError: __init__() got an unexpected keyword argument 'delete'
> 
> Yep, that's too new to rely on:
> 
>   https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory
> 
>   Changed in version 3.12: Added the delete parameter.
> 
> 
> since this is just a debugging aid, perhaps only set the 'delete' param
> when we know python is new enough, and don't bother trying to make
> QEMU_TEST_KEEP_SCRATCH=1 work on older python

Thanks, for tracking this down. I'm going to drop the patch.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]