All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Onur Özkan" <work@onurozkan.dev>
Cc: Mark Brown <broonie@kernel.org>,
	daniel.almeida@collabora.com, aliceryhl@google.com,
	dakr@kernel.org, airlied@gmail.com, simona@ffwll.ch,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	lgirdwood@gmail.com, ojeda@kernel.org,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 1/1] drm/tyr: make SRAM supply optional like panthor
Date: Thu, 12 Feb 2026 13:22:22 +0100	[thread overview]
Message-ID: <20260212132222.0708d190@fedora> (raw)
In-Reply-To: <20260212151644.4c179594@nimda>

On Thu, 12 Feb 2026 15:16:44 +0300
Onur Özkan <work@onurozkan.dev> wrote:

> On Thu, 12 Feb 2026 11:34:41 +0000
> Mark Brown <broonie@kernel.org> wrote:
> 
> > On Thu, Feb 12, 2026 at 01:05:38PM +0300, Onur Özkan wrote:  
> > > On rk3588s, `dmesg | grep 'tyr'` logs:
> > > 
> > >   tyr fb000000.gpu: supply SRAM not found, using dummy regulator
> > > 
> > > This happens because Tyr calls Regulator<Enabled>::get() for SRAM,
> > > which goes through the non-optional regulator_get() path. If the
> > > device tree doesn't provide sram-supply, regulator core falls back
> > > to a dummy regulator and writes that log.  
> >   
> > > Panthor handles SRAM as optional and tolerates missing sram-supply.  
> > 
> > Does the RAM really work without power?  
> 
> If the platform has no separate sram-supply (meaning that rail is
> coupled to mali), RAM should still be powered and work fine. Panthor
> already relies on this model by treating sram-supply as optional and
> as far as I can see there are no RAM issues on Panthor.

Yep, some SoC integration have just one power-rail for everything in
the GPU, others have two. The sram-supply is documented as optional in
the DT bindings, so I think that's the right thing to do.

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> 
> - Onur


  parent reply	other threads:[~2026-02-12 12:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12 10:05 [PATCH v2 0/1] drm/tyr: make SRAM supply optional like panthor Onur Özkan
2026-02-12 10:05 ` [PATCH v2 1/1] " Onur Özkan
2026-02-12 11:34   ` Mark Brown
2026-02-12 12:16     ` Onur Özkan
2026-02-12 12:21       ` Mark Brown
2026-02-12 12:46         ` Boris Brezillon
2026-02-12 13:13           ` Mark Brown
2026-02-12 13:51             ` Boris Brezillon
2026-02-12 18:30               ` Onur Özkan
2026-02-13 12:15                 ` Liviu Dudau
2026-02-13 12:42                   ` Boris Brezillon
2026-02-13 12:59                   ` Onur Özkan
2026-02-13 10:57         ` Liviu Dudau
2026-02-13 15:54           ` Mark Brown
2026-02-12 12:22       ` Boris Brezillon [this message]
2026-02-12 13:10         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260212132222.0708d190@fedora \
    --to=boris.brezillon@collabora.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=broonie@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.