All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Junxian Huang <huangjunxian6@hisilicon.com>
Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, linuxarm@huawei.com,
	tangchengchang@huawei.com
Subject: Re: [PATCH for-next 3/3] RDMA/hns: Support congestion control algorithm parameter configuration
Date: Thu, 12 Feb 2026 18:57:34 +0200	[thread overview]
Message-ID: <20260212165734.GI12887@unreal> (raw)
In-Reply-To: <20260206103110.3414311-4-huangjunxian6@hisilicon.com>

On Fri, Feb 06, 2026 at 06:31:10PM +0800, Junxian Huang wrote:
> From: Chengchang Tang <tangchengchang@huawei.com>
> 
> hns RoCE supports 4 congestion control algorithms. Each algorihm
> involves multiple parameters. Support configuring these parameters
> by debugfs.
> 
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_debugfs.c | 278 +++++++++++++++++++
>  drivers/infiniband/hw/hns/hns_roce_debugfs.h |  25 ++
>  drivers/infiniband/hw/hns/hns_roce_device.h  |  25 ++
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c   |  66 +++++
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.h   | 140 ++++++++++
>  5 files changed, 534 insertions(+)

Please remove all these complexity, delayed work, multiple configuration options in one file,
provide one directory with multiple files. Each file is a key, which can accept multiple
values and not like it is implemented now.

Also, please add examples to this commit message.

Thanks

  reply	other threads:[~2026-02-12 16:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 10:31 [PATCH for-next 0/3] RDMA/hns: Support congestion control algorithm parameter configuration by debugfs Junxian Huang
2026-02-06 10:31 ` [PATCH for-next 1/3] RDMA/hns: Initialize seqfile before creating file Junxian Huang
2026-02-06 10:31 ` [PATCH for-next 2/3] RDMA/hns: Add write support to debugfs Junxian Huang
2026-02-12 16:55   ` Leon Romanovsky
2026-02-13  7:52     ` Junxian Huang
2026-02-13 16:07       ` Leon Romanovsky
2026-02-06 10:31 ` [PATCH for-next 3/3] RDMA/hns: Support congestion control algorithm parameter configuration Junxian Huang
2026-02-12 16:57   ` Leon Romanovsky [this message]
2026-02-13  8:36     ` Junxian Huang
2026-02-13 16:12       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260212165734.GI12887@unreal \
    --to=leon@kernel.org \
    --cc=huangjunxian6@hisilicon.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=tangchengchang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.