From: Al Viro <viro@zeniv.linux.org.uk>
To: Askar Safin <safinaskar@gmail.com>
Cc: christian@brauner.io, hpa@zytor.com, jack@suse.cz,
linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org,
werner@almesberger.net
Subject: Re: [RFC] pivot_root(2) races
Date: Thu, 12 Feb 2026 19:25:08 +0000 [thread overview]
Message-ID: <20260212192508.GP3183987@ZenIV> (raw)
In-Reply-To: <20260212132345.2571124-1-safinaskar@gmail.com>
On Thu, Feb 12, 2026 at 04:23:45PM +0300, Askar Safin wrote:
> Al Viro <viro@zeniv.linux.org.uk>:
> > The interesting part is whether
> > we want to deal with the possibility of errors at that point...
>
> You mean that finding topmost overmount of root of namespace may fail?
>
> Current code in mntns_install indeed can fail, at least theoretically:
>
> https://elixir.bootlin.com/linux/v6.19-rc5/source/fs/namespace.c#L6243
>
> But I argue that this line is unnessesary and should be simply replaced
> with call to topmost_overmount (which, as well as I understand, cannot
> fail).
The pathological case to consider would be something like e.g. NFS root with
referral right at the place we are mounting...
prev parent reply other threads:[~2026-02-12 19:22 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 0:34 [RFC] pivot_root(2) races Al Viro
2026-02-09 5:49 ` Linus Torvalds
2026-02-09 5:53 ` H. Peter Anvin
2026-02-09 6:34 ` Al Viro
2026-02-09 6:44 ` Linus Torvalds
2026-02-09 11:53 ` Christian Brauner
2026-02-12 17:17 ` Askar Safin
2026-02-12 19:11 ` Linus Torvalds
2026-02-12 19:31 ` H. Peter Anvin
2026-02-13 9:51 ` Aleksa Sarai
2026-02-13 17:47 ` Askar Safin
2026-02-13 20:27 ` H. Peter Anvin
2026-02-13 20:35 ` H. Peter Anvin
2026-02-13 22:25 ` Al Viro
2026-02-13 23:00 ` H. Peter Anvin
2026-02-13 23:41 ` Al Viro
2026-02-13 23:40 ` H. Peter Anvin
2026-02-14 12:42 ` Christian Brauner
2026-02-15 0:48 ` H. Peter Anvin
2026-02-17 8:37 ` Christian Brauner
2026-02-14 16:20 ` Askar Safin
2026-02-15 0:49 ` H. Peter Anvin
2026-02-13 13:46 ` Aleksa Sarai
2026-02-13 15:03 ` H. Peter Anvin
2026-02-13 17:47 ` Linus Torvalds
2026-02-13 18:27 ` Askar Safin
2026-02-13 18:39 ` Linus Torvalds
2026-02-13 20:00 ` H. Peter Anvin
2026-02-14 15:31 ` Askar Safin
2026-02-15 0:52 ` H. Peter Anvin
2026-02-14 12:15 ` Christian Brauner
2026-02-14 16:18 ` Linus Torvalds
2026-02-14 17:40 ` Al Viro
2026-02-17 8:35 ` Christian Brauner
2026-02-13 18:42 ` H. Peter Anvin
2026-02-13 20:08 ` H. Peter Anvin
2026-02-12 19:22 ` Al Viro
2026-02-13 17:34 ` Askar Safin
2026-02-13 22:28 ` Al Viro
2026-02-14 16:16 ` Askar Safin
2026-02-12 13:23 ` Askar Safin
2026-02-12 19:25 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212192508.GP3183987@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=christian@brauner.io \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=safinaskar@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=werner@almesberger.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.