From: Eric Biggers <ebiggers@kernel.org>
To: Simon Weber <simon.weber.39@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
tytso@mit.edu, adilger.kernel@dilger.ca, tahsin@google.com,
Anthony Durrer <anthonydev@fastmail.com>
Subject: Re: [PATCH v2] ext4: fix journal credit check when setting fscrypt context
Date: Thu, 12 Feb 2026 16:07:20 -0800 [thread overview]
Message-ID: <20260213000720.GA2191@quark> (raw)
In-Reply-To: <20260207100148.724275-4-simon.weber.39@gmail.com>
On Sat, Feb 07, 2026 at 10:53:03AM +0100, Simon Weber wrote:
> if (handle) {
> + /*
> + * Since the inode is new it is ok to pass the XATTR_CREATE flag. This
> + * is necessary to match the reamining journal credits check in the
> + * set_handle function with the credits allocated for the new inode.
> + */
Typo: reamining => remaining
Otherwise this looks good.
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
- Eric
next prev parent reply other threads:[~2026-02-13 0:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 9:53 [PATCH v2] ext4: fix journal credit check when setting fscrypt context Simon Weber
2026-02-13 0:07 ` Eric Biggers [this message]
2026-02-22 8:11 ` Simon Weber
2026-02-22 20:28 ` Eric Biggers
2026-03-26 11:57 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260213000720.GA2191@quark \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=anthonydev@fastmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon.weber.39@gmail.com \
--cc=tahsin@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.