Re: [PATCH v6 5/6] power: supply: max77759: add charger driver

[kernel test robot <lkp@intel.com>]

Hi Amit,

kernel test robot noticed the following build errors:

[auto build test ERROR on 8dfce8991b95d8625d0a1d2896e42f93b9d7f68d]

url:    https://github.com/intel-lab-lkp/linux/commits/Amit-Sunil-Dhamne-via-B4-Relay/dt-bindings-mfd-maxim-max77759-reference-power-supply-schema-and-add-regulator-property/20260214-111637
base:   8dfce8991b95d8625d0a1d2896e42f93b9d7f68d
patch link:    https://lore.kernel.org/r/20260214-max77759-charger-v6-5-28c09bda74b4%40google.com
patch subject: [PATCH v6 5/6] power: supply: max77759: add charger driver
config: powerpc64-randconfig-001-20260214 (https://download.01.org/0day-ci/archive/20260214/202602141606.igFDFWAJ-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260214/202602141606.igFDFWAJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602141606.igFDFWAJ-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/power/supply/max77759_charger.c:623:4: error: cannot jump from this goto statement to its label
     623 |                         goto err;
         |                         ^
   drivers/power/supply/max77759_charger.c:631:2: note: jump bypasses initialization of variable with __attribute__((cleanup))
     631 |         guard(mutex)(&chg->retry_lock);
         |         ^
   include/linux/cleanup.h:414:15: note: expanded from macro 'guard'
     414 |         CLASS(_name, __UNIQUE_ID(guard))
         |                      ^
   include/linux/compiler.h:168:2: note: expanded from macro '__UNIQUE_ID'
     168 |         __PASTE(__UNIQUE_ID_,                                   \
         |         ^
   include/linux/compiler_types.h:16:23: note: expanded from macro '__PASTE'
      16 | #define __PASTE(a, b) ___PASTE(a, b)
         |                       ^
   include/linux/compiler_types.h:15:24: note: expanded from macro '___PASTE'
      15 | #define ___PASTE(a, b) a##b
         |                        ^
   <scratch space>:18:1: note: expanded from here
      18 | __UNIQUE_ID_guard_461
         | ^
   drivers/power/supply/max77759_charger.c:615:3: error: cannot jump from this goto statement to its label
     615 |                 goto err;
         |                 ^
   drivers/power/supply/max77759_charger.c:631:2: note: jump bypasses initialization of variable with __attribute__((cleanup))
     631 |         guard(mutex)(&chg->retry_lock);
         |         ^
   include/linux/cleanup.h:414:15: note: expanded from macro 'guard'
     414 |         CLASS(_name, __UNIQUE_ID(guard))
         |                      ^
   include/linux/compiler.h:168:2: note: expanded from macro '__UNIQUE_ID'
     168 |         __PASTE(__UNIQUE_ID_,                                   \
         |         ^
   include/linux/compiler_types.h:16:23: note: expanded from macro '__PASTE'
      16 | #define __PASTE(a, b) ___PASTE(a, b)
         |                       ^
   include/linux/compiler_types.h:15:24: note: expanded from macro '___PASTE'
      15 | #define ___PASTE(a, b) a##b
         |                        ^
   <scratch space>:18:1: note: expanded from here
      18 | __UNIQUE_ID_guard_461
         | ^
   drivers/power/supply/max77759_charger.c:606:3: error: cannot jump from this goto statement to its label
     606 |                 goto err;
         |                 ^
   drivers/power/supply/max77759_charger.c:631:2: note: jump bypasses initialization of variable with __attribute__((cleanup))
     631 |         guard(mutex)(&chg->retry_lock);
         |         ^
   include/linux/cleanup.h:414:15: note: expanded from macro 'guard'
     414 |         CLASS(_name, __UNIQUE_ID(guard))
         |                      ^
   include/linux/compiler.h:168:2: note: expanded from macro '__UNIQUE_ID'
     168 |         __PASTE(__UNIQUE_ID_,                                   \
         |         ^
   include/linux/compiler_types.h:16:23: note: expanded from macro '__PASTE'
      16 | #define __PASTE(a, b) ___PASTE(a, b)
         |                       ^
   include/linux/compiler_types.h:15:24: note: expanded from macro '___PASTE'
      15 | #define ___PASTE(a, b) a##b
         |                        ^
   <scratch space>:18:1: note: expanded from here
      18 | __UNIQUE_ID_guard_461
         | ^
   3 errors generated.


vim +623 drivers/power/supply/max77759_charger.c

   591	
   592	static void psy_work_item(struct work_struct *work)
   593	{
   594		struct max77759_charger *chg =
   595			container_of(work, struct max77759_charger, psy_work.work);
   596		union power_supply_propval current_limit, online;
   597		int ret;
   598	
   599		ret = power_supply_get_property(chg->tcpm_psy,
   600						POWER_SUPPLY_PROP_CURRENT_MAX,
   601						&current_limit);
   602		if (ret) {
   603			dev_err(chg->dev,
   604				"Failed to get CURRENT_MAX psy property, ret=%d",
   605				ret);
   606			goto err;
   607		}
   608	
   609		ret = power_supply_get_property(chg->tcpm_psy, POWER_SUPPLY_PROP_ONLINE,
   610						&online);
   611		if (ret) {
   612			dev_err(chg->dev,
   613				"Failed to get ONLINE psy property, ret=%d",
   614				ret);
   615			goto err;
   616		}
   617	
   618		if (online.intval && current_limit.intval) {
   619			ret = set_input_current_limit(chg, current_limit.intval);
   620			if (ret) {
   621				dev_err(chg->dev,
   622					"Unable to set current limit, ret=%d", ret);
 > 623				goto err;
   624			}
   625	
   626			charger_set_mode(chg, MAX77759_CHGR_MODE_CHG_BUCK_ON);
   627		} else {
   628			charger_set_mode(chg, MAX77759_CHGR_MODE_OFF);
   629		}
   630	
   631		guard(mutex)(&chg->retry_lock);
   632	
   633		if (chg->psy_work_retry_cnt)
   634			dev_dbg(chg->dev, "chg psy_work succeeded after %u tries",
   635				chg->psy_work_retry_cnt);
   636		chg->psy_work_retry_cnt = 0;
   637		return;
   638	
   639	err:
   640		charger_set_mode(chg, MAX77759_CHGR_MODE_OFF);
   641		guard(mutex)(&chg->retry_lock);
   642	
   643		if (chg->psy_work_retry_cnt >= MAX_NUM_RETRIES) {
   644			dev_err(chg->dev, "chg psy work failed, giving up");
   645			return;
   646		}
   647	
   648		++chg->psy_work_retry_cnt;
   649		dev_dbg(chg->dev, "Retrying %u/%u chg psy_work",
   650			chg->psy_work_retry_cnt, MAX_NUM_RETRIES);
   651		schedule_delayed_work(&chg->psy_work,
   652				      msecs_to_jiffies(PSY_WORK_RETRY_DELAY_MS));
   653	}
   654	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki