From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
David Wei <dw@davidwei.uk>, <linux-kselftest@vger.kernel.org>,
Nimrod Oren <noren@nvidia.com>
Subject: Re: [PATCH net] selftests: net: fix timeout passed as positional argument to communicate()
Date: Sun, 15 Feb 2026 09:23:00 -0800 [thread overview]
Message-ID: <20260215092300.48ece07b@kernel.org> (raw)
In-Reply-To: <20260215125149.2106612-1-gal@nvidia.com>
On Sun, 15 Feb 2026 14:51:49 +0200 Gal Pressman wrote:
> The cited commit refactored the hardcoded timeout=5 into a parameter,
> but dropped the keyword from the communicate() call.
> Since Popen.communicate()'s first positional argument is 'input' (not
> 'timeout'), the timeout value is silently treated as stdin input and the
> call never enforces a timeout.
>
> Pass timeout as a keyword argument to restore the intended behavior.
Makes sense, but looks like
tools/testing/selftests/drivers/net/netpoll_basic.py
fails now:
https://netdev-ctrl.bots.linux.dev/logs/vmksft/net-drv/results/519460/3-netpoll-basic-py/stdout
I think bpftrace() needs to pass the timeout to cmd().
Probably something like the timeout param that it's passed + 5 sec?
--
pw-bot: cr
prev parent reply other threads:[~2026-02-15 17:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 12:51 [PATCH net] selftests: net: fix timeout passed as positional argument to communicate() Gal Pressman
2026-02-15 17:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260215092300.48ece07b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.