From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Egorenkov <egorenar@linux.ibm.com>
Cc: akpm@linux-foundation.org, bhe@redhat.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, kexec@lists.infradead.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v2 1/1] s390/kexec: Make KEXEC_SIG available when CONFIG_MODULES=n
Date: Mon, 16 Feb 2026 10:08:29 +0100 [thread overview]
Message-ID: <20260216090829.12756A41-hca@linux.ibm.com> (raw)
In-Reply-To: <20260216062916.818071-1-egorenar@linux.ibm.com>
On Mon, Feb 16, 2026 at 07:29:16AM +0100, Alexander Egorenkov wrote:
> The commit c8424e776b09 ("MODSIGN: Export module signature definitions")
> replaced the dependency of KEXEC_SIG on SYSTEM_DATA_VERIFICATION with
> the dependency on MODULE_SIG_FORMAT. This change disables KEXEC_SIG
> in s390 kernels built with MODULES=n if nothing else selects
> MODULE_SIG_FORMAT.
>
> Furthermore, the signature verification in s390 kexec does not require
> MODULE_SIG_FORMAT because it requires only the struct module_signature and,
> therefore, does not depend on code in kernel/module_signature.c.
>
> But making ARCH_SUPPORTS_KEXEC_SIG depend on SYSTEM_DATA_VERIFICATION
> is also incorrect because it makes KEXEC_SIG available on s390 only
> if some other arbitrary option (for instance a file system or device driver)
> selects it directly or indirectly.
>
> To properly make KEXEC_SIG available for s390 kernels built with MODULES=y
> as well as MODULES=n _and_ also not depend on arbitrary options selecting
> SYSTEM_DATA_VERIFICATION, we set ARCH_SUPPORTS_KEXEC_SIG=y for s390 and
> select SYSTEM_DATA_VERIFICATION when KEXEC_SIG=y.
>
> Fixes: c8424e776b09 ("MODSIGN: Export module signature definitions")
> Suggested-by: Heiko Carstens <hca@linux.ibm.com>
> Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> ---
>
> Changes v1 -> v2:
> - Let S390 config option select SYSTEM_DATA_VERIFICATION if KEXEC_SIG is selected
>
> arch/s390/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks!
prev parent reply other threads:[~2026-02-16 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 6:29 [PATCH v2 1/1] s390/kexec: Make KEXEC_SIG available when CONFIG_MODULES=n Alexander Egorenkov
2026-02-16 9:08 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260216090829.12756A41-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=egorenar@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.