From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Kees Cook <kees@kernel.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2][next] iwlegacy: Avoid multiple -Wflex-array-member-not-at-end warnings
Date: Mon, 16 Feb 2026 19:38:08 +0100 [thread overview]
Message-ID: <20260216183808.GA10063@wp.pl> (raw)
In-Reply-To: <202602091212.743C6B9B7C@keescook>
On Mon, Feb 09, 2026 at 12:46:23PM -0800, Kees Cook wrote:
> @@ -2664,7 +2668,8 @@ struct il3945_beacon_notif {
> } __packed;
>
> struct il4965_beacon_notif {
> - struct il4965_tx_resp beacon_notify_hdr;
> + struct il4965_tx_resp_hdr beacon_notify_hdr;
> + __le32 status;
> __le32 low_tsf;
> __le32 high_tsf;
> __le32 ibss_mgr_status;
>
>
> What do folks think?
Both options, with __struct_group(), and this one, are ok for me.
Regards
Stanislaw
prev parent reply other threads:[~2026-02-16 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 4:38 [PATCH v2][next] iwlegacy: Avoid multiple -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2026-02-09 20:46 ` Kees Cook
2026-02-09 6:23 ` Gustavo A. R. Silva
2026-02-09 22:20 ` Kees Cook
2026-02-09 7:22 ` Gustavo A. R. Silva
2026-02-16 18:40 ` Stanislaw Gruszka
2026-02-16 3:42 ` Gustavo A. R. Silva
2026-02-16 18:38 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260216183808.GA10063@wp.pl \
--to=stf_xl@wp.pl \
--cc=gustavoars@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.