From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B5B13E02A for ; Mon, 16 Feb 2026 22:54:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771282459; cv=none; b=Qck3l4XLbDxDFFQBAT00eK4QcnBg+IcR/LL9tOxoKskM9owqJZ9YdlJOEyh7nAnyUxfu84YGWqGSyycOjjhF6K0PGRI5/kPkkOxzfPC6J3pO1PZvL5s/dKrtxmBZYemOu0Aaiy7XLVah8Fvd/JBvfQWRd85ydH53A9aHo++DN5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771282459; c=relaxed/simple; bh=pnu7hjetaw0FKyhlaCjUFsBuTJWa5tX0kkH34ud2MWo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uboje4y0Wlj/ZH3niao7pjonV93JZQgQTDfRmn269gKEn/HecF4/Ny0NigyqXTqKLh541WUSydWywnaN7zhdzDALNGQnOijDWjAWMQcSA5zDcJSlf72g8d9QRU5XVVeovg/piTxANpwxkeQJIxqqGae9mHH3ZSIMKUPr5xkInpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iikfyT4q; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iikfyT4q" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4834826e555so36951325e9.2 for ; Mon, 16 Feb 2026 14:54:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771282457; x=1771887257; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=aTBSy1jG8jaynLD/O0gtItasS3/A/EdinnMNGp8DTWc=; b=iikfyT4qPg7gAQkW/kCGC/T29ZJ+4kgI6KhCKTAypsNTRx6ZfKa6ShVeimEHXhvyks DKlhPxr79lWQoHW8wpJHVDvQ7ttoiaP9bFtAFj83aLq+HQ085gMgK8C+SiWxzz04h63H Y7whx5j6tZDNkRv7LOc/CrFenYsYQ9EsZfIceyzDGbpxIWga9V7HcC7FsiJNsnVq84Oh RneXVY3nAD86lIhy4j4OKDlYA1e2sKS0AIkoT/XxWvi9u9ovrPeSavWSozHZvQ88fJgD Lftf4s3cp+0hSDdMXa9zhNyjRmp4G669qF8RpdNRARIH8zdgDq7fP2aXra9mPEwX0+5B ZVCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771282457; x=1771887257; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aTBSy1jG8jaynLD/O0gtItasS3/A/EdinnMNGp8DTWc=; b=tRz9g0jr+c4BJGYbFIwaqLuwo9i/1qh26F4Z2cuDBxSCegoPRln0ZfW/RYnUhnp1Qg SYWZF6Ag9vpmj8wTd5dVh24k9pAmwZSGTOnIQ8ysCkZqewJzITurMIjXVeYopXFHHVu1 G9YuNO9uJuwWx7sMl4pdMH2ZrlexhaKMcm/CN3SNb16vvroy/gwEYO+53lUOeRLsL0jK mfObdxbHMQCfh0/9wdgeQr+xpPvYFX2V14nclyRT8bfyw1lKj/LziwK3Lkz6uN3YBgmZ ZDrPzwN/aUmoWvK6kKqBNU/9Y3YV189O3Dqrd3la7b+wdwCr0pbsYhsjfV2Tj6/psELw AsMQ== X-Forwarded-Encrypted: i=1; AJvYcCVRPg6GwodkAMd15l8dHZEvPCHiMYGbS+sK/YKMnRyLS/rSNSW5Z6aH6Vl6bN0qG49p34d3HCx5RzB+TIU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywt2pxAAdrnBLoo2xHaOG7pF6HRY9zBIri/7kaKMuXLJZagULSB Sf3lS3cidUD32X4S5rZKI/iQ22mL9bOmv5ahVPQpdHOC1zt0lf/KEgIg X-Gm-Gg: AZuq6aKP1R/bdigJyh/ytwTlZbcXQ81wdp81jfeJ++IasUkWT24Z1gF/ULzzr5EL0t1 9ueUCPKn6dqkOl17F9iWVdUAu7iPzoaBNf0eN2lDNfCVhV8UiLg1F73gagyIy8Z3ZkI0tDUnlE4 qRakNGQWd7H+QAgIrtYrGmuRZ66kjj+yfWlf8x2o8izgQXBTf7x9qAMTXCu+aLUx2JbKDXJEKwI n8bAQVbih/ElermGv45WKTcVpjulcsNDtmK8vc2CZ6MqvVZT1+1EPfGJGXmrzOig9q2MXojm6i2 iw8V2A5Cx16FwfM9i8Og6CZtZbKkZCJG6u2Vh1X9rewqx4RCTqyguBvFMHq6EVtcPm3+0AxXt9O c7z7s1gzTMqLT6MCqX5FzEVb3ObD7UfeAjuzctBlyg9kE4AEwAFppqc6yvJXsYGVskqZe/4UnL9 38yqyICbfxzDZVe45s92/T0HGqRNVxjU12ATSQ8QGK2291ldv5DcomoRwH291lQs8t X-Received: by 2002:a05:600c:35c2:b0:483:6de6:37ad with SMTP id 5b1f17b1804b1-48379c14f3amr167960745e9.34.1771282456782; Mon, 16 Feb 2026 14:54:16 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835dd0deeasm424120455e9.12.2026.02.16.14.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 14:54:16 -0800 (PST) Date: Mon, 16 Feb 2026 22:54:15 +0000 From: David Laight To: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= Cc: Willy Tarreau , linux-kernel@vger.kernel.org, Cheng Li Subject: Re: [PATCH v2 next 10/11] selftests/nolibc: Increase coverage of printf format tests Message-ID: <20260216225415.0fdf2600@pumpkin> In-Reply-To: <4aa20017-bd4f-4ec1-a007-552907877c71@t-8ch.de> References: <20260206191121.3602-1-david.laight.linux@gmail.com> <20260206191121.3602-11-david.laight.linux@gmail.com> <4aa20017-bd4f-4ec1-a007-552907877c71@t-8ch.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 16 Feb 2026 21:23:50 +0100 Thomas Wei=C3=9Fschuh wrote: > On 2026-02-06 19:11:20+0000, david.laight.linux@gmail.com wrote: > > From: David Laight > >=20 > > Extra tests include: > > - %%, including ignored modifiers. > > - Invalid formats copied to output buffer (matches glibc). > > - Left aligned output "%-..." > > - Zero padding "%0...". > > - "(nil)" for NULL pointers (matches glibc). > > - Alternate form "%#x" (prepends 0x in non-zero). > > - Field precision as well as width, printf("%.0d", 0) is "". > > - Variable length width and precision "%*.*d". > > - Length qualifiers L and ll. > > - Conversion specifiers i and X. > > - More 'corner' cases. > >=20 > > There are no explicit tests of long (l, t or z) because they would > > have to differ between 32bit and 64bit. > >=20 > > Set the expected length to zero for all the non-truncating tests. > > (Annoying when a test is changed.) > >=20 > > Signed-off-by: David Laight > > --- > >=20 > > Changes for v2: > > - Formally patch 11. > > - Remove broken __attribute__ on expect_vfprintf(). > > - Add extra test for "#01x". > >=20 > > tools/testing/selftests/nolibc/nolibc-test.c | 49 +++++++++++++++----- > > 1 file changed, 37 insertions(+), 12 deletions(-) =20 >=20 > (...) >=20 > > + CASE_TEST(num_pad_trunc);EXPECT_VFPRINTF(40, " 0000000000",= "%040d", 5); break; /* max 30 '0' can be added */ =20 >=20 > This fails in 'libc-test' with glibc and musl: >=20 > 32 num_pad_trunc "00000000000000000000" should be " 0000000000" = [FAIL] I've a plan for that - the test needs skipping. I can use a -40 to avoid another parameter. David >=20 > > + CASE_TEST(number_prec); EXPECT_VFPRINTF(0, " 00005", "%10.5d", = 5); break; =20 >=20 > (...)